Re: [openobex-users] [PATCH 1/2] USB transport support

[Alexander K. <ak...@se...>]

Marcel Holtmann wrote:
> don't try to change any global code. Meaning the MTU assignment you try
> to sneak in. Send a patch for this upfront.

This change sets MTU to the maximum value for USB transport only - for 
any other case it leaves things exactly as they were before. Note that 
Nokia handsets won't work with default MTU values, and it makes sense to 
always use the max MTU for USB anyway. I also rearranged the code a tiny 
bit, swapping the assignment of self->mtu_* and self->*_msg, so that 
USB-specific code is only in the first assignment. I think it's easy to 
see that the change is safe and correct. Do you really need a separate 
patch for it?

> What about all this -x crap in your patch. Do you heard of the diff
> option for a ignore file?

Somehow missed it. Will fix.

> And please do one patch for adding USB support to the library. This must
> include all changes in lib/ (including usbobex.[ch]). Another patch for
> the apps/ can follow later.

Sure. I splitted usbobex.[ch] into a separate patch because you told me 
so before. By the way, the apps should be made a part of the library, 
and not a separate tree.

Alex