From: Marcel H. <ma...@ho...> - 2005-08-29 21:59:53
|
Hi Christian, > >I was valgrinding my obex app and bumped into a memory leak in openobex. > >The attached patch fixes this leak [...] > > Your patch looks sound to me. I'll give it some more time and wait for > comments though. > If there are no objections I'll commit it to CVS. the patch looks ok on the first review, but please be careful. Last time I reviewed such a patch I came to the conclusion that they tried to fix a memory leak that was an application problem and if I had applied that patch we would have seen a lot of segmentation faults, because of double freed memory. Regards Marcel |