Re: [openobex-users] getaddrinfo() vs _XOPEN_SOURCE=500

[Hendrik S. <po...@he...>]

Zitat von Iain Hibbert <pl...@ry...>:

> Hi
>
> One more issue with building openobex on NetBSD is that getaddrinfo() and
> struct addrinfo are shielded behind XOPEN_SOURCE >= 520 restrictions, and
> in obex_tcp.c the
>
> #define _XOPEN_SOURCE 500
>
> means that they are excluded..  I can't find a citation for the 520 value,
> but the NetBSD guys are generally pretty strict about standards
> conformance and the following webpages
>
> The Single UNIX ® Specification, Version 2 (_XOPEN_SOURCE=500)
>   http://pubs.opengroup.org/onlinepubs/007908799/xsh/compilation.html
>
> The Open Group Base Specifications Issue 6 (_XOPEN_SOURCE=600)
>   http://pubs.opengroup.org/onlinepubs/000095399/functions/xsh_chap02_02.html
>
> seem to imply that version X/Open 5.0 did not define them, where 6.0
> does.. Would bumping it to 600 as below cause any problems?

http://pubs.opengroup.org/onlinepubs/009695399/functions/getaddrinfo.html
says:
"First released in Issue 6. Derived from the XNS, Issue 5.2 specification."
So 520 or 600 should both be the correct value, 600 would be on the safe side.

Can you add a "---" line here, so "git am" can use it? You can send  
all of your patches in one set using "git send-email" :-)

> diff --git a/apps/obex_tcp.c b/apps/obex_tcp.c
> index 17204fa..831952e 100644
> --- a/apps/obex_tcp.c
> +++ b/apps/obex_tcp.c
> @@ -22,7 +22,7 @@
>  #ifdef HAVE_CONFIG_H
>  #include <config.h>
>  #endif
> -#define _XOPEN_SOURCE 500
> +#define _XOPEN_SOURCE 600
>
>  #ifdef _WIN32
>  #include <winsock2.h>