Re: [openMSX-devel] Testing RC1

[Maarten t. H. <ma...@tr...>]

On Tuesday 25 May 2004 10:20, Manuel Bilderbeek wrote:

> 1) for some reason, desktop shortcuts don't work with GNOME (I'm running
> 2.4.x). [...]
> Ah! I checked the differences and found the problem. Change Categories
> to this line:
> Categories=Application;Emulator;Game;
> So, add "Application". Please fix this in CVS!

Both "Emulator" and "Game" are perfectly fine categories according to the 
spec. So it seems your GNOME version is not compliant. However, since the 
change doesn't seem to cause any problems (at least on my machine), it is an 
acceptable workaround.

> 2) Catapult has assertions enabled.

Since Catapult is not a heavy-computing app like openMSX, I don't think there 
is a performance reason to disable assertions. Disabling them to get less 
crashes is probably false hope: assertions are there for a reason. If you 
disable a triggered assert, the program is likely to crash, run amok or hang, 
but very unlikely to function normally.

> I know this, because at the first 
> run of the new binary, I got this after closing Catapult while openMSX
> was running:
> catapult: src/openMSXController.cpp:268: wxString
> openMSXController::GetPendingCommand(): Assertion `!m_commands.empty()'
> failed.
> The problem is that this bug isn't easily reproducible...

We could try reviewing the code to see if we can find a scenario in which this 
assert can be triggered. If that doesn't give a solution in an hour or so, 
we'll just have to release with the problem still there. We could, just for 
the release version, replace the assert by defensive programming, to avoid 
the crash. I can't judge whether that's an option, because I'm not familiar 
enough with the code.

Bye,
		Maarten