From: Wouter V. <m97...@us...> - 2013-12-22 21:07:53
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "openMSX (main)". The branch, master has been updated via 6b4e8458fc28dec7611a46f242eb3538ac27cbc7 (commit) from 498cf3db92402c3b9ab3d49f17d3020c5daf3b22 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b4e8458fc28dec7611a46f242eb3538ac27cbc7 Author: wouter <ver...@gm...> Date: Sun Dec 22 21:59:26 2013 +0100 Don't lazily create 'reversebar_fadeout_time' setting Before this patch, in TAS mode (set mode TAS) when you start openmsx, you triggered the following problem: warning: Error executing delayed command: can't read "::reversebar_fadeout_time": no such variable The problem was that "reversebar_fadeout_time" was created in "_reverse.tcl", but that script is only loaded on demand (and there is no check for settings yet), so the setting didn't exist yet when the mode.tcl script tried to use it. Fixed by moving the creation of "reversebar_fadeout_time" to "reverse.tcl". (Luckily) we already had a non-lazy part of the reverse script. ----------------------------------------------------------------------- Summary of changes: share/scripts/_reverse.tcl | 2 -- share/scripts/reverse.tcl | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/share/scripts/_reverse.tcl b/share/scripts/_reverse.tcl index e50248f..daa2a7a 100644 --- a/share/scripts/_reverse.tcl +++ b/share/scripts/_reverse.tcl @@ -327,8 +327,6 @@ variable prev_x 0 variable prev_y 0 variable overlayOffset -user_setting create float reversebar_fadeout_time "Time it takes for the reverse bar to fade out when it's not in focus. Set to 0 for no fade out at all." 5.0 0.0 100.0 - set_help_text toggle_reversebar \ {Enable/disable an on-screen reverse bar. This will show the recorded 'reverse history' and the current position in\ diff --git a/share/scripts/reverse.tcl b/share/scripts/reverse.tcl index e19deb9..8d8f124 100644 --- a/share/scripts/reverse.tcl +++ b/share/scripts/reverse.tcl @@ -38,6 +38,10 @@ Possible values for this setting: gui Reverse + reverse_bar enabled (see 'help toggle_reversebar') } $reverse::default_auto_enable_reverse +user_setting create float "reversebar_fadeout_time" \ +{Time it takes for the reverse bar to fade out when it's not in focus. Set to 0 for no fade out at all. +} 5.0 0.0 100.0 + # TODO hack: # The order in which the startup scripts are executed is not defined. But this hooks/post-receive -- openMSX (main) |