[openMSX-commits] SF.net SVN: openmsx:[8359] openmsx/trunk/src/sound/SDLSoundDriver.cc

[<m97...@us...>]

Revision: 8359
          http://openmsx.svn.sourceforge.net/openmsx/?rev=8359&view=rev
Author:   m9710797
Date:     2008-11-21 19:35:32 +0000 (Fri, 21 Nov 2008)

Log Message:
-----------
fixed potential race-condition

found by helgrind (part of valgrind)

Modified Paths:
--------------
    openmsx/trunk/src/sound/SDLSoundDriver.cc

Modified: openmsx/trunk/src/sound/SDLSoundDriver.cc
===================================================================
--- openmsx/trunk/src/sound/SDLSoundDriver.cc	2008-11-21 19:35:16 UTC (rev 8358)
+++ openmsx/trunk/src/sound/SDLSoundDriver.cc	2008-11-21 19:35:32 UTC (rev 8359)
@@ -51,18 +51,20 @@
 
 SDLSoundDriver::~SDLSoundDriver()
 {
-	delete[] mixBuffer;
-
 	SDL_CloseAudio();
 	SDL_QuitSubSystem(SDL_INIT_AUDIO);
+
+	delete[] mixBuffer;
 }
 
 void SDLSoundDriver::reInit()
 {
+	SDL_LockAudio();
 	memset(mixBuffer, 0, bufferSize * sizeof(short));
 	readIdx  = 0;
 	writeIdx = (5 * bufferSize) / 8;
 	filledStat = 1.0;
+	SDL_UnlockAudio();
 }
 
 void SDLSoundDriver::mute()


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.