#518 Crash on Windows when copying file with weird chars to dir-as-disk

[Manuel Bilderbeek]

The following scenario (happened on Windows 7 64 bit):

<lars_> Set Disk A as DIRASDISK to a EMPTY DIR
<lars_> Set Disk B with this DSK (BCF 3) -> http://www.msx.org/download/downloads/diskmags/bcf/bcf3.zip
<lars_> start to basic, and use the folowing command : COPY"B:." to "A:</lars_></lars_></lars_>

result: "Fatal Error: MultiByteToWideChar failed: 1113"

I'm sure it was not convertible (those file names contain 0xC9 bytes in them), but it's a bit harsh to get a fatal error due to this.

(Note that on Linux it works fine and even the software (BCF DiskStation 3) still runs on that dir-as-disk copy.)

So, the question is: is there a better way to handle this?

[Manuel Bilderbeek]

Thanks to Vampier:

openmsx.exe!utf8::utf8to16(const std::basic_string<char,std::char_traits\<char>,std::allocator\<char> > & utf8={...}) Line 65 C++
openmsx.exe!openmsx::FileOperations::openFile(const std::basic_string<char,std::char_traits\<char>,std::allocator\<char> > & filename={...}, const std::basic_string<char,std::char_traits\<char>,std::allocator\<char> > & mode={...}) Line 329 C++
openmsx.exe!openmsx::LocalFile::LocalFile(string_ref filename_={...}, openmsx::File::OpenMode mode=TRUNCATE) Line 53 C++
openmsx.exe!make_unique<openmsx::localfile,string_ref &="" __ptr64,enum="" openmsx::file::openmode="" __ptr64="">(string_ref & p1={...}, openmsx::File::OpenMode & p2=TRUNCATE) Line 43 C++
openmsx.exe!openmsx::init(string_ref url={...}, openmsx::File::OpenMode mode=TRUNCATE) Line 21 C++
openmsx.exe!openmsx::File::File(string_ref url={...}, openmsx::File::OpenMode mode=TRUNCATE) Line 49 C++
openmsx.exe!openmsx::DirAsDSK::exportToHostFile(openmsx::DirAsDSK::DirIndex dirIndex={...}, const std::basic_string<char,std::char_traits\<char>,std::allocator\<char> > & hostName={...}) Line 1177 C++
openmsx.exe!openmsx::DirAsDSK::exportToHost(openmsx::DirAsDSK::DirIndex dirIndex={...}, openmsx::DirAsDSK::DirIndex dirDirIndex={...}) Line 1129 C++
openmsx.exe!openmsx::DirAsDSK::writeDIREntry(openmsx::DirAsDSK::DirIndex dirIndex={...}, openmsx::DirAsDSK::DirIndex dirDirIndex={...}, const openmsx::MSXDirEntry & newEntry={...}) Line 1246 C++
openmsx.exe!openmsx::DirAsDSK::writeDIRSector(unsigned int sector=7, openmsx::DirAsDSK::DirIndex dirDirIndex={...}, const openmsx::SectorBuffer & buf={...}) Line 1208 C++
openmsx.exe!openmsx::DirAsDSK::writeSectorImpl(unsigned __int64 sector_=7, const openmsx::SectorBuffer & buf={...}) Line 853 C++
openmsx.exe!openmsx::SectorAccessibleDisk::writeSector(unsigned __int64 sector=7, const openmsx::SectorBuffer & buf={...}) Line 56 C++
openmsx.exe!openmsx::SectorBasedDisk::writeTrackImpl(unsigned char track='\0', unsigned char side='\0', const openmsx::RawTrack & input={...}) Line 30 C++
openmsx.exe!openmsx::Disk::writeTrack(unsigned char track='\0', unsigned char side='\0', const openmsx::RawTrack & input={...}) Line 28 C++
openmsx.exe!openmsx::RealDrive::writeTrack(const openmsx::RawTrack & track={...}) Line 301 C++
openmsx.exe!openmsx::DriveMultiplexer::writeTrack(const openmsx::RawTrack & track={...}) Line 94 C++
openmsx.exe!openmsx::WD2793::doneWriteSector() Line 752 C++
openmsx.exe!openmsx::WD2793::executeUntil(const openmsx::EmuTime time={...}, int userData=0) Line 433 C++
openmsx.exe!openmsx::Scheduler::scheduleHelper(const openmsx::EmuTime limit={...}) Line 159 C++
openmsx.exe!openmsx::Scheduler::schedule(const openmsx::EmuTime limit={...}) Line 70 C++
openmsx.exe!openmsx::CPUCore<openmsx::z80type>::execute2(bool fastForward=false) Line 2572 C++
openmsx.exe!openmsx::CPUCore<openmsx::z80type>::execute(bool fastForward=false) Line 2526 C++
openmsx.exe!openmsx::MSXCPU::execute(bool fastForward=false) Line 164 C++
openmsx.exe!openmsx::MSXMotherBoard::Impl::execute() Line 731 C++
openmsx.exe!openmsx::MSXMotherBoard::execute() Line 1363 C++
openmsx.exe!openmsx::Reactor::run(openmsx::CommandLineParser & parser={...}) Line 610 C++
openmsx.exe!openmsx::SDL_main(int argc=1, char * * argv=0x000000eb2ae8fa90) Line 153 C++
openmsx.exe!SDL_main(int argc=1, char * * argv=0x000000eb2ae5bb50) Line 182 C++
openmsx.exe!main(int argc=1, char * * argv=0x000000eb2ae5bb50) Line 315 C
openmsx.exe!__tmainCRTStartup() Line 255 C
openmsx.exe!mainCRTStartup() Line 165 C
kernel32.dll!00007ffde79d15cd() Unknown
ntdll.dll!00007ffde9b243d1() Unknown</openmsx::z80type></openmsx::z80type></char></char,std::char_traits\<char></openmsx::localfile,string_ref></char></char,std::char_traits\<char></char></char,std::char_traits\<char></char></char,std::char_traits\<char>