openMSX / Bugs (DISABLED) / #488 wxCatapult: x64 wxCriticalSection::Enter() crash trace

Anonymous - 2013-08-02

No. From the wx docu http://docs.wxwidgets.org/2.8.12/wx_wxevthandler.html#wxevthandleraddpendingevent :

wxEvtHandler::AddPendingEvent

void AddPendingEvent(wxEvent& event)

"This is also the method to call for inter-thread communication---it will post events safely between different threads which means that this method is thread-safe by using critical sections where needed. In a multi-threaded program, you often need to inform the main GUI thread about the status of other working threads and such notification should be done using this method."

Last edit: Anonymous 2013-08-02

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

summary: wxCatapult: ridiculous GUI thread stuff --> wxCatapult: x64 crash trace
Description has changed:

Diff:

--- old
+++ new
@@ -13,12 +13,4 @@
 (14:30:56) Vampier: CRASH!
 (14:32:33) egp_: Vampier: is this x64 build?
 (14:33:39) Vampier: yep
-(14:33:58) egp_: well it seems it adds gui events in the non-GUI thread. 
-This is ridiculously wrong
-(14:33:59) Vampier: Program: ...\derived\x64-VC-Unicode Debug\install\catapult.exe
-(14:33:59) Vampier: File: ..\..\src\openMSXController.cpp
-(14:33:59) Vampier: Line: 730
-(14:34:32) egp_: one has to use a queue to transmit events from another thread to the GUI thread.
-(14:35:13) egp_: Only the very novices at GUI programming do this mistake
-(14:35:51) egp_: This must also be fixed for x32 version.
 ~~~~~~~~~

Priority: 1 --> 5

Anonymous - 2013-08-02

~~~~~~~~~~~~~
// wx/thread.h

if !defined(WXMSW) && !defined(WXMAC)

#define wxCRITSECT_IS_MUTEX 1 #define wxCRITSECT_INLINE inline

else // MSW

#define wxCRITSECT_IS_MUTEX 0 #define wxCRITSECT_INLINE

endif // MSW/!MSW

...

class WXDLLIMPEXP_BASE wxCriticalSection
{
...
// enter the section (the same as locking a mutex)
wxCRITSECT_INLINE void Enter();
...

// src/msw/thread.cpp

void wxCriticalSection::Enter()
{
::EnterCriticalSection((CRITICAL_SECTION *)m_buffer); //line 170
} //line 171
~~~~~~~~~~~

NB: wx seems to at least partially support x64 as there are "#ifdef WIN64" stuffs.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2013-08-02

summary: wxCatapult: x64 crash trace --> wxCatapult: x64 wxCriticalSection::Enter() crash trace
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Manuel Bilderbeek - 2013-08-05

Let's not dive into the code of wxWidgets and assume it's not (very) buggy...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Manuel Bilderbeek - 2014-11-23

status: open --> closed-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Manuel Bilderbeek - 2014-11-23

As there's no way to reproduce this (none is described), let's simply close this bug.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

wxCatapult: x64 wxCriticalSection::Enter() crash trace

Group

Searches

Help

#488 wxCatapult: x64 wxCriticalSection::Enter() crash trace

Discussion

if !defined(WXMSW) && !defined(WXMAC)

else // MSW

endif // MSW/!MSW