[OpenJade-devel] --error-numbers to generic interface

[Bjoern H. <der...@gm...>]

Hi,

  Over at the W3C MarkUp Validator we use the -n/--error-numbers command
line option of the onsgmls tool, we are now trying to switch to the
generic OpenSP interface which currently lacks the functionality. I thus
propose to add ParserEventGeneratorKit::showErrorNumbers as a new
boolean option to the generic interface that corresponds to -n, i.e.,

Index: doc/generic.htm
===================================================================
RCS file: /cvsroot/openjade/sp/doc/generic.htm,v
retrieving revision 1.2
diff -u -p -r1.2 generic.htm
--- doc/generic.htm     9 Dec 1999 23:32:12 -0000       1.2
+++ doc/generic.htm     28 Aug 2004 19:32:25 -0000
@@ -953,6 +953,10 @@ to be generated.
 <code>ParserEventGeneratorKit::outputGeneralEntities</code>
 <dd>
 This will cause <code>GeneralEntityEvent</code>s to be generated.
+<dt>
+<code>ParserEventGeneratorKit::showErrorNumbers</code>
+<dd>
+This corresponds to the <code>-n</code> option of nsgmls.
 </dl>
 <dt>
 <code>

Index: generic/ParserEventGeneratorKit.h
===================================================================
RCS file: /cvsroot/openjade/sp/generic/ParserEventGeneratorKit.h,v
retrieving revision 1.1.4.1
diff -u -p -r1.1.4.1 ParserEventGeneratorKit.h
--- generic/ParserEventGeneratorKit.h   30 Aug 2003 08:26:00 -0000
+++ generic/ParserEventGeneratorKit.h   28 Aug 2004 19:32:26 -0000
@@ -23,7 +23,8 @@ public:
     outputMarkedSections,
     outputGeneralEntities,
     mapCatalogDocument,
-    restrictFileReading
+    restrictFileReading,
+    showErrorNumbers
   };
   enum OptionWithArg {
     addCatalog,

Index: lib/ParserEventGeneratorKit.cxx
===================================================================
RCS file: /cvsroot/openjade/sp/lib/ParserEventGeneratorKit.cxx,v
retrieving revision 1.1.4.1
diff -u -p -r1.1.4.1 ParserEventGeneratorKit.cxx
--- lib/ParserEventGeneratorKit.cxx     30 Aug 2003 08:26:00 -0000
+++ lib/ParserEventGeneratorKit.cxx     28 Aug 2004 19:32:26 -0000
@@ -112,6 +112,9 @@ void ParserEventGeneratorKit::setOption(
   case restrictFileReading:
     impl_->processOption('R', 0);
     break;
+  case showErrorNumbers:
+    impl_->processOption('n', 0);
+    break;
   }
 }

This should ensure compatibility to previous versions. Any objections?

regards.