[oh-tracker] [ openhpi-Bugs-1163498 ] saHpiIdrAreaAdd_T8.c return error code

[SourceForge.net <no...@so...>]

Bugs item #1163498, was opened at 2005-03-15 08:52
Message generated for change (Comment added) made by vadimr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=1163498&group_id=71730

Category: OpenHPI base library
Group: 2.1.1
Status: Open
Resolution: Accepted
Priority: 5
Submitted By: wang, jing (wangjing)
Assigned to: vadim revyakin (vadimr)
Summary: saHpiIdrAreaAdd_T8.c return error code

Initial Comment:
OpenHPI 2.0.3
OpenIPMI 1.3.17
OpenIPMI plugin
Langley


************************************************************
*  TestCase
*
*   Call saHpiIdrAreaAdd() on a IDR which is read only.
*
*   Returns HPI_TEST return codes: PASS, FAIL, 
UNKNOWN, NA
*
*   Expected return:  call returns 
SA_ERR_HPI_READ_ONLY.
*
*
************************************************************/
According to spec, it should return 
SA_ERR_HPI_READ_ONLY, 
actually it return SA_ERR_HPI_INVALID_REQUEST.

----------------------------------------------------------------------

>Comment By: vadim revyakin (vadimr)
Date: 2005-04-29 16:04

Message:
Logged In: YES 
user_id=1133239

Could not reproduce on 2.1.1. This part of source code was 
completely rewritten since 2.0.3.

----------------------------------------------------------------------

Comment By: wang, jing (wangjing)
Date: 2005-03-28 07:04

Message:
Logged In: YES 
user_id=1152287

In OpenIPMI 2.0.3, the code is not like what you have 
pasted, the Default READONLY status= TRUE. Please 
check! (Maybe you have change it in 2.1.x, but not in 2.0.x)

SaErrorT ohoi_get_idr_info(void *hnd, SaHpiResourceIdT rid, 
SaHpiIdrIdT idrid,
                           SaHpiIdrInfoT *idrinfo)
{
        struct oh_handler_state  *handler = hnd;

        OHOI_CHECK_RPT_CAP_IDR();

        idrinfo->IdrId = OHOI_IDR_DEFAULT_ID;
        idrinfo->UpdateCount = 0;
        idrinfo->ReadOnly = SAHPI_TRUE;

        idrinfo->NumAreas = OHOI_AREA_NUM;

        return SA_OK;
}


----------------------------------------------------------------------

Comment By: wang, jing (wangjing)
Date: 2005-03-28 06:24

Message:
Logged In: YES 
user_id=1152287

I mean:
when Idr:ReadOnly ==SAHPI_TRUE, function 
saHpiIdrAreaAdd() should return 
SA_ERR_HPI_READ_ONLY. But actually it returns 
SA_ERR_HPI_INVALID_REQUEST now.

----------------------------------------------------------------------

Comment By: Tariq Shureih (tariqx)
Date: 2005-03-26 02:18

Message:
Logged In: YES 
user_id=118691

 I am not sure I understand how you're getting this result
with the OpenIPMI plug-in.

The test code is:
----snip----
        if (rdr.RdrType == SAHPI_INVENTORY_RDR)
        {
                //
                // Check to see if this is a read-only IDR
                status = saHpiIdrInfoGet(session,
                                         resourceId,
                                        
rdr.RdrTypeUnion.InventoryRec.IdrId,
                                         &IdrInfo);
                if (status != SA_OK)
                {
                        retval = HPI_TEST_NA;
                }
                else
                {
                        // TEST CASE NEEDS a read-only IDR
                        if (IdrInfo.ReadOnly == SAHPI_FALSE)
                        {
                                retval = HPI_TEST_NA;
                        }
                }
        }
-----snip----

If I'm reading this correctly, if the Idr:ReadOnly ==
SAHPI_FALSE then the test is NA.

The IPMI plug-in ALWAYS sets this field to SAHPI_FALSE per:
ipmi_inventory.c:
----snip----
start line 815:
	fru = ohoi_res_info->fru;
	g_mutex_lock(fru->mutex);
	idrinfo->IdrId = OHOI_IDR_DEFAULT_ID;
	idrinfo->UpdateCount = fru->update_count;
	idrinfo->ReadOnly = SAHPI_FALSE;
----snip-----

so shouldn't this test be N/A ?

----------------------------------------------------------------------

Comment By: wang, jing (wangjing)
Date: 2005-03-15 14:00

Message:
Logged In: YES 
user_id=1152287

The same thing occurs in saHpiIdrFieldSet_T8.c.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=1163498&group_id=71730