From: SourceForge.net <no...@so...> - 2013-05-28 23:51:35
|
Bugs item #3613753, was opened at 2013-05-22 15:42 Message generated for change (Comment added) made by dr_mohan You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3613753&group_id=71730 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: OpenHPI base library Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Michele Baldessari (mbaldessari) Assigned to: dr_mohan (dr_mohan) Summary: Fix another set of references before checks Initial Comment: Attached trivial patch that fixes another set of references used before the check. Found by the smatch tool ---------------------------------------------------------------------- >Comment By: dr_mohan (dr_mohan) Date: 2013-05-28 16:51 Message: Fixed in #7541 ---------------------------------------------------------------------- Comment By: dr_mohan (dr_mohan) Date: 2013-05-28 16:50 Message: sysfs plugin changes are not checked in with the infrastructure changes. It needs more changes. Will open a bug for that. ---------------------------------------------------------------------- Comment By: dr_mohan (dr_mohan) Date: 2013-05-24 13:57 Message: Michele, Looks like it is better to separate this into two patches. One for infrastructure and one for the sysfs plugin. Sysfs plugin patch is more involved as few more checks need to be made and I do not know if any one is maintaining that plugin. Hope that is ok. Mohan ---------------------------------------------------------------------- Comment By: dr_mohan (dr_mohan) Date: 2013-05-24 13:13 Message: looks like the check for tmprdr needs to be done following the while loop too, in the sysfs plugin. It could core dump if the tmprdr is NULL at the end of the loop. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3613753&group_id=71730 |