[oh-tracker] [ openhpi-Bugs-3613754 ] snmp_bc_set_hotswap_state() has a likely wrong test

[SourceForge.net <no...@so...>]

Bugs item #3613754, was opened at 2013-05-22 15:47
Message generated for change (Tracker Item Submitted) made by mbaldessari
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3613754&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: SNMP Client plugin
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Michele Baldessari (mbaldessari)
Assigned to: Nobody/Anonymous (nobody)
Summary: snmp_bc_set_hotswap_state() has a likely wrong test

Initial Comment:
--- a/openhpi/trunk/plugins/snmp_bc/snmp_bc_hotswap.c
+++ b/openhpi/trunk/plugins/snmp_bc/snmp_bc_hotswap.c
@@ -140,7 +140,7 @@ SaErrorT snmp_bc_set_hotswap_state(void *hnd,
                return(SA_ERR_HPI_INTERNAL_ERROR);
        }
 
-       if (resinfo->cur_state != SAHPI_HS_STATE_INSERTION_PENDING ||
+       if (resinfo->cur_state != SAHPI_HS_STATE_INSERTION_PENDING &&
            resinfo->cur_state != SAHPI_HS_STATE_EXTRACTION_PENDING) {
                snmp_bc_unlock_handler(custom_handle);
                return(SA_ERR_HPI_INVALID_REQUEST);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3613754&group_id=71730