Re: [Openhpi-devel] Patch review request for modifications in hpiclient code to fix the issue: 3425850 - hpipower command is misleading the user

[Beecherla, H. <hem...@hp...>]

Hi Anton,
Thank you very much for your suggestion, I am waiting for few more comments from others.
I will take a look in to your suggestion.


Regards,
Hemantha Reddy

-----Original Message-----
From: Anton Pak [mailto:ant...@pi...] 
Sent: Tuesday, February 19, 2013 12:50 PM
To: ope...@li...; Beecherla, Hemantha
Subject: Re: [Openhpi-devel] Patch review request for modifications in hpiclient code to fix the issue: 3425850 - hpipower command is misleading the user

Hello Hemantha,

I have to say to current hpipower code is very misleading too. :)

See you are creating an array of 16 power states.
What about extending the COMPUTER_DATA struct to store current power state?

	Anton Pak

On Tue, 19 Feb 2013 23:34:19 +0400, Beecherla, Hemantha <hem...@hp...> wrote:

> Hi All,
> Hpipower client code is modified in the attached patch to fix below 
> issue,
> 3425850 - hpipower command is misleading the 
> user<http://sourceforge.net/tracker/?func=detail&aid=3425850&group_id=
> 71730&atid=532251>
>
> Please review the patch and provide if any suggestion.
>
> Thank you very much in advance :).
>
> Regards,
> Hemantha Reddy