[oh-tracker] [ openhpi-Bugs-3529771 ] Strange if block in the watchdog action trigger code

[SourceForge.net <no...@so...>]

Bugs item #3529771, was opened at 2012-05-25 07:52
Message generated for change (Comment added) made by avpak
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3529771&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Dynamic Simulator plugin
Group: Future
Status: Closed
>Resolution: None
Priority: 5
Private: No
Submitted By: Anton Pak (avpak)
Assigned to: Lars Wetzel (larswetzel)
Summary: Strange if block in the watchdog action trigger code

Initial Comment:
File: plugins/dynamic_simulator/new_sim_watchdog.cpp
Function: NewSimulatorWatchdog::TriggerAction()

The following code contains very strange if block:

================
if ( m_state != PRETIMEOUT );
    TriggerAction( PRETIMEOUT );
TriggerAction( TIMEOUT );
================

----------------------------------------------------------------------

>Comment By: Anton Pak (avpak)
Date: 2012-05-25 12:38

Message:
Lars, thanks!
I suspected that it was simple but "m_state != PRETIMEOUT" brought some
uncertainty.
If it had been "m_state == PRETIMEOUT", I'd have been more sure! :)


----------------------------------------------------------------------

Comment By: Lars Wetzel (larswetzel)
Date: 2012-05-25 12:32

Message:
Fix in #7439
:-) No comment

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3529771&group_id=71730