[oh-tracker] [ openhpi-Bugs-3289939 ] auto-insertion timeout can not be enforced

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Bugs item #3289939, was opened at 2011-04-19 16:28
Message generated for change (Comment added) made by dr_mohan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3289939&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OpenHPI Daemon
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: dr_mohan (dr_mohan)
Assigned to: Anton Pak (avpak)
Summary: auto-insertion timeout can not be enforced

Initial Comment:
The fix for 2798408 makes it mandatory on all plugins that auto-insertion timeout is supported. But not all plugins can support it. oa_soap does not support it and SAHPI_DOMAIN_CAP_AUTOINSERT_READ_ONLY capability and auto-insertion timeout = 0 is a perfect default for it. Right now oa_soap plugin does not work at all.

So the fix for 2798408 needs to be rolled back or modified.

----------------------------------------------------------------------

>Comment By: dr_mohan (dr_mohan)
Date: 2011-12-23 17:39

Message:
We will go through the change and see if we can add it also. But this does
not help at all. Current code just calls the set_autoinsert_timeout
function and expects it to return SA_OK, other wise it throws CRIT error
which could exit the program. But the function  is going to return
SA_ERR_HPI_READ_ONLY which is perfectly normal. If the timeout is read only
then there is no need to call the set function and it is avoided. 

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-12-23 00:42

Message:
What about the approach in attached aii.diff?

----------------------------------------------------------------------

Comment By: dr_mohan (dr_mohan)
Date: 2011-12-22 16:11

Message:
Please review the patch that avoids calling the set_autoinsert_timeout
function of the insert timeout is readonly and the timeout passed is 0.  In
the other cases where the hardware supports the autoinsert_timeout then
SA_OK could be expected.

----------------------------------------------------------------------

Comment By: dr_mohan (dr_mohan)
Date: 2011-12-20 17:27

Message:
saHpiAutoInsertTimeoutSet needs to be implemented even if the plugin does
not support it with SA_ERR_HPI_READ_ONLY as output. So if the
set_autoinsert_timeout need not be called if ai_timeout is 0 and the
timeout is read only, if it is called with ai_timeout of 0 then
SA_ERR_HPI_READ_ONLY then SA_ERR_HPI_READ_ONLY is a valid return, not a
critical error.

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-07-25 15:14

Message:
Well, I am trying to see from broader view.
How it works for different plug-ins and different setups.
What if user configures RW or/and non-zero timeout and oa_soap handler and
so on.

----------------------------------------------------------------------

Comment By: dr_mohan (dr_mohan)
Date: 2011-07-25 15:07

Message:
The check could depend only on the ! SAHPI_DOMAIN_CAP_AUTOINSERT_READ_ONLY
instead of both (timeout value also).

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-07-25 14:57

Message:
And also what use is there in error messages in
oa_soap_get_autoextract_timeout()? It seem the function just returns zero
value but very aloud.

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-07-25 14:54

Message:
Several thoughts.

So OA_SOAP handler cannot co-exist with IPMI Direct(for example) in the
same setup, right?

As for oa_soap_set_autoinsert_timeout() in oa_soap_hotswap.c I see no use
in error messages. there It seems that error code SA_ERR_HPI_READ_ONLY
tells the same in a better way.

Could we set a rule that any OpenHPI plug-in must have default zero
auto-insert timeout on startup? Without it making RO timeout in config may
produce irregularity.

Why the timeout is so important? In HPI spec  there is a resource
capability SAHPI_HS_CAPABILITY_AUTOINSERT_IMMEDIATE that says the resource
will be activated immediately regardless of the timeout.

----------------------------------------------------------------------

Comment By: dr_mohan (dr_mohan)
Date: 2011-07-25 14:22

Message:
The plugin works ok with your earlier modifications. When the
SAHPI_DOMAIN_CAP_AUTOINSERT_READ_ONLY is set and the AI timeout is 0 it
should not make the call to set the timeout. It produces some bad messages
in the /var/log/messages. New patch basically avoids it. 

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-07-21 04:25

Message:
I still fail to grasp your arguments.
In what way does oa_soap not work now?

----------------------------------------------------------------------

Comment By: dr_mohan (dr_mohan)
Date: 2011-07-20 15:16

Message:
Let me know if this patch is ok. It uses the AI timeout that was set in rev
#7302

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-04-29 15:57

Message:
I made AI timeout read only by default in trunk (rev. #7302)

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-04-21 09:31

Message:
I guess if plug-in doesn't support auto-insertion timeout, then the plug-in
must not provide abi->set_autoinsert_timeout.

And one more suggestion:
How about setting SAHPI_HS_CAPABILITY_AUTOINSERT_IMMEDIATE for all oa_soap
resources?

HPI-B.03.02 spec says:
** SAHPI_HS_CAPABILITY_AUTOINSERT_IMMEDIATE
** This capability indicates that the resource ignores the auto insertion
** timeout value(s) configured for the domain(s) of which it is a member,
** but instead begins its auto insertion policy immediately upon
insertion.

----------------------------------------------------------------------

Comment By: dr_mohan (dr_mohan)
Date: 2011-04-21 09:27

Message:
Changing the default openhpi.conf to read-only zero timeout will work if we
issue the handler->abi->set_autoinsert_timeout(handler->hnd, ai_timeout)
call only when the SAHPI_DOMAIN_CAP_AUTOINSERT_READ_ONLY is false and/or
the timeout is set to a non-zero value.

This way other plugins that support the above call could set the parameters
in the openhpi.conf file and make the calls.

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2011-04-19 16:45

Message:
Well, auto-insertion timeout can be configured RO with
OPENHPI_AUTOINSERT_TIMEOUT_READONLY parameter in openhpi.conf. And default
timeout value can be set with OPENHPI_AUTOINSERT_TIMEOUT parameter.
So it is just a matter of configuration.
Guess we can change default openhpi.conf to read-only zero timeout.
What say?

Hope that limited hot swap support in the oa_soap plug-in shall not be
restriction of the whole daemon.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3289939&group_id=71730