[oh-tracker] [ openhpi-Bugs-3031579 ] oHpi* functions are not declared correct

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Bugs item #3031579, was opened at 2010-07-19 16:23
Message generated for change (Comment added) made by avpak
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3031579&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OpenHPI base library
Group: 2.15.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Anton Pak (avpak)
Assigned to: Anton Pak (avpak)
Summary: oHpi* functions are not declared correct

Initial Comment:
OpenHPI provides oHpiVersionGet, oHpiHandlerCreate, oHpiHandlerDestroy, oHpiHandlerInfo, oHpiHandlerGetNext, oHpiHandlerFind, oHpiHandlerRetry, oHpiGlobalParamGet, oHpiGlobalParamSet, oHpiInjectEvent functions.

See include/oHpi.h

The functions are similar to the functions for base HPI spec.
But base HPI spec function is declared in the following way:
-----------------------------------------------------------------------
SaErrorT SAHPI_API saHpiSessionOpen (
    SAHPI_IN  SaHpiDomainIdT      DomainId,
    SAHPI_OUT SaHpiSessionIdT     *SessionId,
    SAHPI_IN  void                *SecurityParams
);
-----------------------------------------------------------------------
oHpi* function is declated in the following way:
-----------------------------------------------------------------------
SaErrorT oHpiHandlerInfo(oHpiHandlerIdT id, oHpiHandlerInfoT *info);
-----------------------------------------------------------------------

The SAHPI_API  and SAHPI_IN/SAHPI_OUT were not used in oHpi* function declaration.
It creates some problems on Windows where SAHPI_API shall be __declspec(dllimport) __cdecl or __declspec(dllexport) __cdecl.
A linker oHpi* function simply does not see the functions at all.

----------------------------------------------------------------------

>Comment By: Anton Pak (avpak)
Date: 2010-07-20 13:43

Message:
Fixed in trunk (rev #7129)

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2010-07-19 23:30

Message:
The patch is attached

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=3031579&group_id=71730