[oh-tracker] [ openhpi-Bugs-2726887 ] issue with marshalling of control state(saHpiControlGet)

[SourceForge.net <no...@so...>]

Bugs item #2726887, was opened at 2009-04-02 08:26
Message generated for change (Settings changed) made by ricwhite
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=2726887&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OpenHPI base library
>Group: 2.14.0
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Anton Pak (avpak)
Assigned to: Anton Pak (avpak)
Summary: issue with marshalling of control state(saHpiControlGet)

Initial Comment:
File: openhpid/oh_client.cpp
Function: saHpiControlGet

HPI-B.03( Section 7.3.2) says:

For text Controls, the line number to read is passed in via CtrlState–>StateUnion.Text.Line.

As an input parameter, the CtrlState–>Type value is not significant for this function and is ignored. It is thus not necessary to set CtrlState–>Type to any valid value, even when CtrlState is being used to provide input parameters for specific types of Controls.

SAF test suite contains a lot of code of the following kind:

SaHpiCtrlStateT state;
state.StateUnion.Text.Line = line_num;
saHpiControlGet( sid, rid, ctrl, &mode, &state );

In this situation CtrlState–>Type is undefined and this fact produces marshalling assertion.

However latest OpenHPI sets CtrlState–>Type internally in SAHPI_CTRL_TYPE_OEM to avoid marshalling assertion.

But there is still an issue : CtrlState–>StateUnion.Text.Line value may be incorrectly marshalled because of CtrlState–>Type = SAHPI_CTRL_TYPE_OEM.


The patch is attached.

----------------------------------------------------------------------

Comment By: Anton Pak (avpak)
Date: 2009-04-02 09:19

Message:
Fixed in trunk (rev #6982)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=2726887&group_id=71730