[oh-tracker] [ openhpi-Bugs-1877606 ] saHpiControlSet(): incorrect digital Control state check

[SourceForge.net <no...@so...>]

Bugs item #1877606, was opened at 2008-01-22 13:14
Message generated for change (Settings changed) made by shuah
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=1877606&group_id=71730

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OpenHPI base library
Group: 2.10.2
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Shuah Khan (shuah)
Assigned to: Nobody/Anonymous (nobody)
Summary: saHpiControlSet(): incorrect digital Control state check

Initial Comment:
saHpiControlSet() has incorrect check to look for the following SAFHPI Spec condition: SA_ERR_HPI_INVALID_REQUEST is returned when SAHPI_CTRL_STATE_PULSE_ON is issued to a digital Control,
which is ON (in either manual or auto mode). It is also returned when SAHPI_CTRL_STATE_PULSE_OFF is issued
to a digital Control, which is OFF (in either manual or auto mode).

The current code in saHpiControlSet() checks and returns correct return value if the current state is  SAHPI_CTRL_STATE_PULSE_OFF and the requested state isSAHPI_CTRL_STATE_PULSE_OFF. However it doesn't check amd return when the current state is SAHPI_CTRL_STATE_PULSE_OFF and the requested state is SAHPI_CTRL_STATE_OFF. The same is applicable to SAHPI_CTRL_STATE_PULSE_ON and SAHPI_CTRL_STATE_ON.

As a result the Saftest saHpiControlSet/20.c fails.




----------------------------------------------------------------------

Comment By: Shuah Khan (shuah)
Date: 2008-01-23 16:44

Message:
Logged In: YES 
user_id=1884926
Originator: YES

Submitted fix to the trunk and the 2.10.x branch to be pulled into 2.10.2

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=532251&aid=1877606&group_id=71730