Menu

#1640 utils/event_utils.c has duplicate definition of oh_dup_event

3.0.0
closed-out-of-date
6
2012-06-04
2011-06-28
dr_mohan
No

The same function
struct oh_event *oh_dup_event(struct oh_event *old_event)
exists in openhpid/event.c also

If we compile with --disable-shared the compile fails because of this duplicate definition.
It succeeds if we remove the function from utils/event_utils.

Discussion

  • Anton Pak

    Anton Pak - 2011-06-29

    I see no duplicate definition in source code.
    Suspect there is double linking of the same static library.
    Right?

     
  • dr_mohan

    dr_mohan - 2011-06-29

    I do not know how it was not caught but the
    struct oh_event *oh_dup_event(struct oh_event *old_event)
    function exists in
    utils/event_utils.c
    and
    openhpid/event.c

    We could remove it from utils/event_utils.c

     
  • Anton Pak

    Anton Pak - 2011-06-29

    Ah, right!
    Well, plug-ins use the function, so the right place for the function is in the utils library.
    I removed it from openhpid/event.c in trunk (rev. #7337)
    Does it work for you now?

     
  • Anton Pak

    Anton Pak - 2011-09-19
    • milestone: 1365031 --> 2040045
     
  • Anton Pak

    Anton Pak - 2012-04-20
    • milestone: 2040045 --> 2691517
     
  • Anton Pak

    Anton Pak - 2012-06-04
    • milestone: 2691517 --> 3.0.0
    • status: open --> closed-out-of-date
     
  • Anton Pak

    Anton Pak - 2012-06-04

    The change was included in 3.0.0.