sorry, i haven't gotten a chance to look at it in detail. i looked a little into window functions because i wasn't familiar with them, and found that they have a whole pile of potential syntax. i haven't had the time to digest the possibilities and determine whether tacking that functionality on the FunctionCall makes the most sense or not.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
so, i didn't directly use the patch you provided. i went with a new WindowDefinitionClause class (which should support all of the standard-defined sql syntax for this construct). This can be added to the FunctionCall or can be used with a SelectQuery to define named window definitions.
this is fixed in trunk now and will be in the 2.1.7 release.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry, i attach new patch file.
Looks like window functions (from sql 2003) bring a whole pile of new syntax: https://htmlpreview.github.io/?https://raw.githubusercontent.com/ronsavage/SQL/master/sql-2003-2.bnf.html#window%20function
Last edit: James Ahlborn 2017-02-09
use in this case CustomSql() extremely inconvenient
New patch with JavaDoc and additional method for order specification.
Are any changes required on my side?
sorry, i haven't gotten a chance to look at it in detail. i looked a little into window functions because i wasn't familiar with them, and found that they have a whole pile of potential syntax. i haven't had the time to digest the possibilities and determine whether tacking that functionality on the FunctionCall makes the most sense or not.
just an fyi, i think i have a handle on this now, should be able get something in over the next week or so.
so, i didn't directly use the patch you provided. i went with a new WindowDefinitionClause class (which should support all of the standard-defined sql syntax for this construct). This can be added to the FunctionCall or can be used with a SelectQuery to define named window definitions.
this is fixed in trunk now and will be in the 2.1.7 release.
thanks