#214 Safe references in OpalCall class

[Borko Jandras]

In OpalCall class, references to OpalConnection instances are referenced using PSafePtr objects. As the obtained reference is used only for invoking methods, a read-only or read-write lock is unnecessary. Whether the connection instance needs to lock itself while executing the given method is not something the caller should worry about.

This patch uses PSafeReference in all such cases. The patch in tracker item 1686620 is associated with this patch.

[Borko Jandras]

patch for call.cxx

[Robert Jongbloed]

Logged In: YES
user_id=774817
Originator: NO

Actually I would like to leave most of these the way they are. While in principle the called should probably be responsible for the lock type, in practice it is much safer to have the caller do the locking. For example, user code overrides a virtual that is called in one of these places and that user forgets to do the lock then WE get told of crashes that are not our fault. It's "better" to make it more difficult for people to stuff up.