[Openh323-devel] [PATCH] Trivial zeroing of v4l2_buffer

[Sam R. <sam...@gm...>]

This buglet was apparently causing a bunch of problems with the ricoh
webcam driver in Ekiga.

Also, when the VIDIOC_QBUF call failed, pwlib would fall back to
read(2) mode, where it would do something very bizarre: in-place YUYV
to YUV420P conversion.  This would corrupt the image with two
horizontal gray bars as it filled interlaced YUV420P pixel data over
the buffer that also contained the non-interlaced YUYV source data.

Thanks...
-Sam Revitch

Index: plugins/vidinput_v4l2/vidinput_v4l2.cxx
===================================================================
RCS file: /cvsroot/openh323/pwlib/plugins/vidinput_v4l2/vidinput_v4l2.cxx,v
retrieving revision 1.22
diff -u -p -r1.22 vidinput_v4l2.cxx
--- plugins/vidinput_v4l2/vidinput_v4l2.cxx     19 Feb 2007 22:26:14
-0000      1.22
+++ plugins/vidinput_v4l2/vidinput_v4l2.cxx     20 Feb 2007 07:12:43 -0000
@@ -335,6 +335,7 @@ BOOL PVideoInputDevice_V4L2::Start()
     for (unsigned int i=0; i<videoBufferCount; i++) {

        struct v4l2_buffer buf;
+       memset(&buf, 0, sizeof(buf));
        buf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
        buf.memory = V4L2_MEMORY_MMAP;
        buf.index = i;