opengrads-devel

Re: [Opengrads-devel] patch for gadap

[Arlindo da S. <da...@al...>]

On Tue, Sep 9, 2008 at 9:28 AM, Patrice Dumas <per...@fr...> wrote:

> Hello,
>
> Here is a simple patch for gadap
>

We have a version of gadap in the supplibs, and then there is the one that
Jeniffer posted recently. All my builds use the supplibs version.  Have you
had a chance to reconcile these? It has been on my to do list but I haven't
been able to get to it yet.

Jennifer: have you done any comparison against the supplib sources?


> * missing cstring includes
> * use libdap namespace
>
> I don't know if the libdap namespace use causes gadap not to build with
> libdap < 3.8.0 anymore.



Yep, the API changes were so extensive that this is not practical. This is
one of the reasons for renaming the files from "dods" to "dap".  I'd suggest
forgetting about versions pre 3.8.0.


> If so, it'll need to be conditionalized, could
> you please test it?
>

I can tell you: no way to use the current gadap with the old API without
very tedious analysis and testing. In my view it is not worth it.


>
> I think that it would be nice to have shared libraries with libtool
> support. Would you accept if I do that?
>

I thought we had that already once we autocinfiscated the gadap sources.
What else do we need to do?
In any event, when building the supplibs I always set "--disabled-shared
--enable-static".


> Also is there a repository to track your development and avoid doing
> patches against old sources? That would be very convenient (and for
> grads, too...).
>


Do you think you could update the supplib repository with yours+Jennifer
patches? At least that repository will be current, and could be used as a
reference for communication with Jennifer (at least it would have the
history log). You can either import on a COLA vendor branch and merge, or
else just overwrite what is in the trunk and check in.  This would be used
for supplibs-2.0.2, whenever we have a new version. I am assuming you ahve
done some type of testing.

   Thank you,

        Arlindo


-- 
Arlindo da Silva
da...@al...

Re: [Opengrads-devel] patch for gadap

[Patrice D. <per...@fr...>]

On Tue, Sep 09, 2008 at 01:03:35PM -0400, Arlindo da Silva wrote:
> 
> Yep, the API changes were so extensive that this is not practical. This is
> one of the reasons for renaming the files from "dods" to "dap".  I'd suggest
> forgetting about versions pre 3.8.0.

Ok.

> I thought we had that already once we autocinfiscated the gadap sources.
> What else do we need to do?

Not a lot, this is indeed really easy after autocinfiscation. The real 
burden is that ABI changes have to be tracked afterwards.

> In any event, when building the supplibs I always set "--disabled-shared
> --enable-static".

Indeed.

> Do you think you could update the supplib repository with yours+Jennifer
> patches? At least that repository will be current, and could be used as a
> reference for communication with Jennifer (at least it would have the
> history log). You can either import on a COLA vendor branch and merge, or
> else just overwrite what is in the trunk and check in. 

This requires libdap > 3.8.0 in the supplibs, is it the case?

Maybe we could wait for the next gadap release with all changes
incorporated to put it in the supplibs, unless this is already 
libdap > 3.8.0 in the supplibs.

> This would be used
> for supplibs-2.0.2, whenever we have a new version. I am assuming you ahve
> done some type of testing.

You're not correctly assuming ;-). I am a packager, not a user of gadap,
so I don't even know how to test it. I just verified that it compiled,
but my changes are very minor. I'll certainly test that I can perform
what I usually do with grads with gadap, but it has to build first, and
I have to package it too, so I'm not there right now.

--
Pat

Re: [Opengrads-devel] patch for gadap

[Arlindo da S. <da...@al...>]

On Thu, Sep 11,
>
> > Do you think you could update the supplib repository with yours+Jennifer
> > patches? At least that repository will be current, and could be used as a
> > reference for communication with Jennifer (at least it would have the
> > history log). You can either import on a COLA vendor branch and merge, or
> > else just overwrite what is in the trunk and check in.
>
> This requires libdap > 3.8.0 in the supplibs, is it the case?


Most importantly, in the GrADS code, both v1.9.0-rc1 and the v2 series.

>
>
> Maybe we could wait for the next gadap release with all changes
> incorporated to put it in the supplibs, unless this is already
> libdap > 3.8.0 in the supplibs.
>

Yes, the version in the supplibs is for libdap > 3.8.0.  A little history.
We had the old gadods that Joe wrote. There were substantial API changes
going from libdap 3.7 to 3.8 and gadap was broken beyond (simple) repair.
Jennifer gave what she had at the time (which had already some mods towards
libdap 3.8) and I hacked it away with help from James. With your help I
revised the autoconfiscation, tests, etc and checked in the supplibs and
have been using it since then for building v1.9 and v2.0. I am not sure if
Jennifer have been tracking the version in the repository or have made
changes starting from a tarball I sent her at some point.

Jennifer current sources appear to have 2 main mods:

1) Change n copyright: from Joe to COLA/IGES, something they had to do
2) Some directory renaming (from m4 to etc)
3) A new function for returning the version number

  I'll try to reconcile.

      Arlindo

-- 
Arlindo da Silva
da...@al...