Re: [Opengrads-devel] patch for gadap

[Patrice D. <per...@fr...>]

On Tue, Sep 09, 2008 at 01:03:35PM -0400, Arlindo da Silva wrote:
> 
> Yep, the API changes were so extensive that this is not practical. This is
> one of the reasons for renaming the files from "dods" to "dap".  I'd suggest
> forgetting about versions pre 3.8.0.

Ok.

> I thought we had that already once we autocinfiscated the gadap sources.
> What else do we need to do?

Not a lot, this is indeed really easy after autocinfiscation. The real 
burden is that ABI changes have to be tracked afterwards.

> In any event, when building the supplibs I always set "--disabled-shared
> --enable-static".

Indeed.

> Do you think you could update the supplib repository with yours+Jennifer
> patches? At least that repository will be current, and could be used as a
> reference for communication with Jennifer (at least it would have the
> history log). You can either import on a COLA vendor branch and merge, or
> else just overwrite what is in the trunk and check in. 

This requires libdap > 3.8.0 in the supplibs, is it the case?

Maybe we could wait for the next gadap release with all changes
incorporated to put it in the supplibs, unless this is already 
libdap > 3.8.0 in the supplibs.

> This would be used
> for supplibs-2.0.2, whenever we have a new version. I am assuming you ahve
> done some type of testing.

You're not correctly assuming ;-). I am a packager, not a user of gadap,
so I don't even know how to test it. I just verified that it compiled,
but my changes are very minor. I'll certainly test that I can perform
what I usually do with grads with gadap, but it has to build first, and
I have to package it too, so I'm not there right now.

--
Pat