Re: [Opengrads-devel] Merging and reconciling GrADS v2.0.a3

[Jennifer A. <jm...@co...>]

Arlindo --
I am happy to hear 2.0.a3 built (almost) perfectly with your supplibs  
and passed your tests. Was the change from Pixel to gaPixel the only  
change needed to get the GUI to build? Did you try out the sdfwrite  
command?

The mods you outline below seem fine with me, but I will check with  
Brian about the main() changes. I asked him about /pytests and he  
would prefer that there is no dependence on python at all, even just  
for testing. Seems like an easy enough thing to package separately,  
if people who are building from source want to use to check on their  
work.

--Jennifer
p.s. I will be on vacation next week, so all this will idle for a  
little while until I get back.

On Aug 15, 2008, at 1:13 AM, Arlindo da Silva wrote:

> Jennifer et al,
>
>    In the previous message I reported that v2.0.a3 (almost) builds  
> out of the tarball with the supplibs-2.0.1.  Here I report the  
> first steps towards having the build mechanism reconciled/merged.
>
> 1) The first step is to bring your sources into the OpenGrADS  
> codebase so that we can approach this from 2 directions. This time  
> I took your sources pretty much AS IS except for:
>
> 	  - Changed #include <config.h> to #include "config.h"; this can  
> be accomplished with
>                   sed -i -e 's/\(# *include \+\)<config.h>/ 
> \1"config.h"/' src/*.c src/*.h
>             This is more than a stylistic patch; <> is usually  
> reserved for system includes.
> 	  - Removed Arlindo's copyright notice in gacfg.c, kept COLA's
> 	  - Changed Pixel to gaPixel in gatypes.h because of conflicts
> 	    with libsx.h
> 	  - Updated copyright notice in pcx11e.[ch]; I'd suggest removing  
> these 2 files altogether.
> 	  - Changed main() to grads_main() in grads.c
> 	  - Introduced main.c and main_win32.c; this will be very  
> important for a user friendly Win32
>             build and is essential for working with DLL extensions  
> later on.
> 	  - Commented out libdap_version() and libgadap_version() in  
> gacfg.c (for now, so that we can
>             use the existing supplibs-2.0.1 "as is").
>
> I am attaching the diffs as well as the full sources (I did not  
> change your build to use main.c). Do you think you could  
> incorporate these mods in your code base so that we can start from  
> a common source code base when working on the build? Some of the  
> licensing patches are important for Pat and his Fedora package  
> (Pat: did I miss anything?) The main.c mod anticipates what I will  
> need for the Win32 build.
>
> 2) With the above source patches I was able to make a full build  
> with the supplibs-2.0.1, including the GUI, using the current  
> opengrads build.
> Like with COLA's build, it passed all tests. For reference I issued  
> the tag grads-2_0_a3-a1; you can check it out with
>
> % gacvs co -r grads-2_0_a3-oga-1 grads
>
> 3) The next step is for Pat to go over the autoconf scripts and  
> reconcile/merge what we have with COLA's. As I said, it would be  
> good if we start with the same sources.
>
> 4) As for the pytests/, it works pretty much as an add-on and we  
> will continue to maintain it at OpenGrADS. I find it extremely  
> useful to check the builds on different platforms and I'ff continue  
> to add to it. This is very separate from PyGrADS, although it  
> include a very small part of it needed to drive the tests.
>
>   Let me know if this is an acceptable plan to you.
>
>   Cheers!
>
>      Arlindo
>
>
>
>
>
> -- 
> Arlindo da Silva
> da...@al...
> <grads_src.diffs><grads_src.tgz>-------------------------------------- 
> -----------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's  
> challenge
> Build the coolest Linux based applications with Moblin SDK & win  
> great prizes
> Grand prize is a trip for two to an Open Source event anywhere in  
> the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/ 
> _______________________________________________
> Opengrads-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opengrads-devel

--
Jennifer M. Adams
IGES/COLA
4041 Powder Mill Road, Suite 302
Calverton, MD 20705
jm...@co...