Menu

#228 writeFieldsGeneralFunctionObject.C fails to build with OpenFOAM 2.2

fixed
nobody
None
normal
minor
Always
none
0.3.2
simpleFunctionObjects
2020-12-15
2015-08-02
No

The file Libraries/simpleFunctionObjects/writeFields/writeFieldsGeneral/writeFieldsGeneralFunctionObject.C is hardcoded to always include basicThermoCloud.H, which doesn't exist in OpenFOAM 2.2 (possibly due to an automatic renaming script that went wrong at OpenCFD).

The fix is provided in attachment in hg bundle and patch formats, where the inclusion is removed and instead the existing class swakFluidThermoCloudType is used instead, since it's the one designed for this.

I only found out about this while diagnosing this: http://www.cfd-online.com/Forums/openfoam-installation/138996-swak4foam-installation-problem.html#post558008

1 Attachments

Discussion

  • Bruno Santos

    Bruno Santos - 2015-08-02

    The patch file... couldn't attach more than one attachment per post... weird...

     
  • Bernhard Gschaider

    Thanks. This only affects 2.2, right?

    I merged the bundle into my develop branch and will push it ASAP

     
    • NAVEEN KUSHWAHA

      NAVEEN KUSHWAHA - 2020-12-14

      Dear Bernhard,
      Could you please tell me , how to merge bundle in develop branch

       
      • Bernhard Gschaider

        The bundle has been merged into the repository in 2015 and has since been part of releases and the development branch of swak4foam
        So there is no need to to merge the bundle anymore
        Nevertheless: the oldest version the swak4foam is currently tested with is 2.3, It may be possible that changes to swak4foam in the last 5 years broke the compilation on 2.2 or older versions. This is unfortunate but I have no plans to look into this
        If you really have to use 2.2 then use

        hg update -r v0.4.0
        

        to checkout the oldest release that has these changes. Of course this would miss the latest features of swak4foam but the basic stuff should be there

         
  • Bernhard Gschaider

    • status: new --> fixed
     
    • NAVEEN KUSHWAHA

      NAVEEN KUSHWAHA - 2020-12-14

      Could you please elaborate the process of fixing this bug.

       
  • chronicnerd

    chronicnerd - 2020-12-02

    How to use this patch, kindly help.

     
  • Bernhard Gschaider

    The patch has been part of swak4Foam for 5 years (so there is no need to apply it if your swak4Foam-sources are younger than that) and was only necessary for OF 2.2 (are you really using that version?)

     
  • chronicnerd

    chronicnerd - 2020-12-02

    Yes, I was using OF2.2, due to some unavoidable reasons. The patch did not work but I managed to figure out something else. Anyways, deeply appreciate the speedy response!!

     
    • NAVEEN KUSHWAHA

      NAVEEN KUSHWAHA - 2020-12-14

      I am facing problem in building it on OF 2.2.0. after patching

       

Log in to post a comment.