Thread: [Openfoam-extend-general] The patch-branch and the git-branch

Status: Beta

Brought to you by: bgschaid, hakan_nilsson, henrus, hjasak, and 2 others

openfoam-extend-general

[Openfoam-extend-general] The patch-branch and the git-branch

From: Bernhard G. <Ber...@ic...> - 2008-09-01 20:08:53

It might have come to your attention[1], that the OpenCFD is offering a
service (via GIT) similar to the the patch-branches on OpenFOAM-extend
which in the long run might make these patch-branches obsolete (which
is a good thing)

Up to now the policy of the OF-extend-patch-branch was to

 * include only bug-fixes (no new features)
 * include only stuff that was accepted by the people from OpenCFD

As a test all the changes supplied by the Git-version were
incorporated into the patch-branch. Two patches from the message board
were missing from the Git and reapplied. So the patch-branch should
contain all the publicly known bug-fixes to OpenFOAM 1.5

One two-sided sword is that int the Git-version there are also
feature additions (which is good) and there was at least one instance
of a code broken by those additions (this was one of the reasons why
the patch-branch adopted the very conservative policy described
above). This one breakage might have been an unfortunate accident. 

To evaluate what the future options for the patch-branch should be I'm
relying on feedback:

 - is the patch-branch actually used?
 - were there problems with it in the past?
 - should it be abandoned in favour of the git-archive?

Bernhard

Footnotes: 
[1]  http://www.opencfd.co.uk/openfoam/download.html#download

Re: [Openfoam-extend-general] The patch-branch and the git-branch

From: Martin B. <bea...@gm...> - 2008-09-02 01:53:59

Hello,

Here is my feedback:


> To evaluate what the future options for the patch-branch should be I'm
> relying on feedback:
>
>  - is the patch-branch actually used?


Yes. At IREQ, we keep both the dev and the patched version available.


>
>  - were there problems with it in the past?


No. You are doing a pretty fine job at maintaining this part of
openfoam-extend Bernhard.


>
>  - should it be abandoned in favour of the git-archive?
>

Not yet.

Let's see how the git archive is maintained and evolving first.

The quality will have to improve. Missing patches and broken code is not
what I call quality.

Martin



> Bernhard
>
> Footnotes:
> [1]  http://www.opencfd.co.uk/openfoam/download.html#download
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Openfoam-extend-general mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openfoam-extend-general
>



-- 
Martin Beaudoin

Re: [Openfoam-extend-general] The patch-branch and the git-branch

From: Håkan N. <ha...@ch...> - 2008-09-02 05:08:03

Hi,

I agree with Martin.

I have the patch version installed.
I had no problems with it.
I can't use the git version at the moment.
I think that since the git version adds new features (and bugs), it should 
be considered as an experimental state of the code. There is also a need 
for a code that is only bug-fixed, and hopefully becoming more and more 
stable.

So, I hope that you are willing to continue with the patched version for a 
while.

At least it would be good to maintain a list of bug fixes, and where to 
find the updated code.

Håkan.

On Mon, 1 Sep 2008, Martin Beaudoin wrote:

> Hello,
>
> Here is my feedback:
>
>
>> To evaluate what the future options for the patch-branch should be I'm
>> relying on feedback:
>>
>>  - is the patch-branch actually used?
>
>
> Yes. At IREQ, we keep both the dev and the patched version available.
>
>
>>
>>  - were there problems with it in the past?
>
>
> No. You are doing a pretty fine job at maintaining this part of
> openfoam-extend Bernhard.
>
>
>>
>>  - should it be abandoned in favour of the git-archive?
>>
>
> Not yet.
>
> Let's see how the git archive is maintained and evolving first.
>
> The quality will have to improve. Missing patches and broken code is not
> what I call quality.
>
> Martin
>
>
>
>> Bernhard
>>
>> Footnotes:
>> [1]  http://www.opencfd.co.uk/openfoam/download.html#download
>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's
>> challenge
>> Build the coolest Linux based applications with Moblin SDK & win great
>> prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Openfoam-extend-general mailing list
>> Ope...@li...
>> https://lists.sourceforge.net/lists/listinfo/openfoam-extend-general
>>
>
>
>
>

-- 
Håkan.

Note that my e-mail address has changed to ha...@ch....
+-------------------------------------------------------------------------+
| Håkan Nilsson                     |                                     |
| Ph.D., Assistant Professor        | Tel:   (+46)31-772 1414             |
| Applied mechanics, Fluid Dynamics | Fax:   (+46)31-18 09 76             |
| Chalmers University of Technology | E-mail:   ha...@ch...          |
| SE-412 96 Gothenburg              | Homepage:                           |
| SWEDEN                            |    http://www.tfd.chalmers.se/~hani |
+-------------------------------------------------------------------------+

Re: [Openfoam-extend-general] The patch-branch and the git-branch

From: Ola W. <ola...@ya...> - 2008-09-02 20:13:05

Hi Bernhard,

I'm but a rather passive part of this illustrious community, but I still 
want to offer a word of appreciation and encouragement...

I think your effort with bug-patched version is very valuable. As Håkan 
says, a version which is slowly but surely getting more and more stable 
and bug-free, but being otherwise frozen, is very valuable. Especially 
when OpenFOAM is applied to industrial applications and more of a  
"production" type of context.

The appearance of OpenCFD's git repository is otherwise a very positive 
development. If OpenCFD is opening up a bit more to the outside world, 
it's a good thing.

Best regards,

Ola



Bernhard Gschaider wrote:
> It might have come to your attention[1], that the OpenCFD is offering a
> service (via GIT) similar to the the patch-branches on OpenFOAM-extend
> which in the long run might make these patch-branches obsolete (which
> is a good thing)
>
> Up to now the policy of the OF-extend-patch-branch was to
>
>  * include only bug-fixes (no new features)
>  * include only stuff that was accepted by the people from OpenCFD
>
> As a test all the changes supplied by the Git-version were
> incorporated into the patch-branch. Two patches from the message board
> were missing from the Git and reapplied. So the patch-branch should
> contain all the publicly known bug-fixes to OpenFOAM 1.5
>
> One two-sided sword is that int the Git-version there are also
> feature additions (which is good) and there was at least one instance
> of a code broken by those additions (this was one of the reasons why
> the patch-branch adopted the very conservative policy described
> above). This one breakage might have been an unfortunate accident. 
>
> To evaluate what the future options for the patch-branch should be I'm
> relying on feedback:
>
>  - is the patch-branch actually used?
>  - were there problems with it in the past?
>  - should it be abandoned in favour of the git-archive?
>
> Bernhard
>
> Footnotes: 
> [1]  http://www.opencfd.co.uk/openfoam/download.html#download
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Openfoam-extend-general mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openfoam-extend-general
>
>   

-- 
____________________________________________
Ola Widlund
Älvkarleövägen 19
SE-115 43  Stockholm
SWEDEN
Tel: +46-(0)8-666 98 79
Mob: +46-(0)70-660 00 03
http://ola.widlund.free.fr

Re: [Openfoam-extend-general] The patch-branch and the git-branch

From: Bernhard G. <Ber...@ic...> - 2008-09-04 20:24:56

>>>>> On Tue, 2 Sep 2008 07:08:07 +0200 (CEST)
>>>>> "HN" == Håkan Nilsson <ha...@ch...> wrote:

    HN> Hi, I agree with Martin.

    HN> I have the patch version installed.  I had no problems with
    HN> it.  I can't use the git version at the moment.  I think that
    HN> since the git version adds new features (and bugs), it should
    HN> be considered as an experimental state of the code. There is
    HN> also a need for a code that is only bug-fixed, and hopefully
    HN> becoming more and more stable.

Well. The incident (breaking of one of my codes) was solved (quite an
easy thing). 

Nevertheless. My current problem is that I use the patch branch to
upgrade our "production"-installation. So my fear is that during
upgrading I will break the OF installation and all runs that will be
scheduled on our cluster after that will fail (until I discover the
mistake). So I guess I'll have to have a test-installation that I
apply patches to before upgrading the production version.

How do you deal with issues like that?

    HN> So, I hope that you are willing to continue with the patched
    HN> version for a while.

I will. And I will have a closer look at the stuff that comes from the
git before commiting it

Only problem is, that currently the patch is rather large because
there are changes between 1.5 and the first revision in the git (so
the git itself can't be used to patch an installation the
patch-version does) so patching currently takes a rather long time

BTW: what I am impressed with is the speed of GIT for downloading

    HN> At least it would be good to maintain a list of bug fixes, and
    HN> where to find the updated code.

    HN> Håkan.

    HN> On Mon, 1 Sep 2008, Martin Beaudoin wrote:

    >> Hello,
    >> 
    >> Here is my feedback:
    >> 
    >> 
    >>> To evaluate what the future options for the patch-branch
    >>> should be I'm relying on feedback:
    >>> 
    >>> - is the patch-branch actually used?
    >> 
    >> 
    >> Yes. At IREQ, we keep both the dev and the patched version
    >> available.
    >> 
    >> 
    >>> - were there problems with it in the past?
    >> 
    >> 
    >> No. You are doing a pretty fine job at maintaining this part of
    >> openfoam-extend Bernhard.
    >> 
    >> 
    >>> - should it be abandoned in favour of the git-archive?
    >>> 
    >> Not yet.
    >> 
    >> Let's see how the git archive is maintained and evolving first.
    >> 
    >> The quality will have to improve. Missing patches and broken
    >> code is not what I call quality.
    >> 
    >> Martin
    >> 
    >> 
    >> 
    >>> Bernhard
    >>> 
    >>> Footnotes: [1]
    >>> http://www.opencfd.co.uk/openfoam/download.html#download
    >>> 
    >>> 
    >>> -------------------------------------------------------------------------
    >>> This SF.Net email is sponsored by the Moblin Your Move
    >>> Developer's challenge Build the coolest Linux based
    >>> applications with Moblin SDK & win great prizes Grand prize is
    >>> a trip for two to an Open Source event anywhere in the world
    >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
    >>> _______________________________________________
    >>> Openfoam-extend-general mailing list
    >>> Ope...@li...
    >>> https://lists.sourceforge.net/lists/listinfo/openfoam-extend-general
    >>> 
    >>

    HN> -- Håkan.

    HN> Note that my e-mail address has changed to ha...@ch....
    HN> +-------------------------------------------------------------------------+
    HN> | Håkan Nilsson | | | Ph.D., Assistant Professor | Tel:
    HN> (+46)31-772 1414 | | Applied mechanics, Fluid Dynamics | Fax:
    HN> (+46)31-18 09 76 | | Chalmers University of Technology |
    HN> E-mail: ha...@ch... | | SE-412 96 Gothenburg | Homepage:
    HN> | | SWEDEN | http://www.tfd.chalmers.se/~hani |
    HN> +-------------------------------------------------------------------------+


-- 
---------------------------------------------------------------------------
DI Bernhard F.W. Gschaider
---------------------------------------------------------------------------
EMail: 	Ber...@ic...
WWW  : www.ice-sf.at
Jabber : bgs...@ja...
Tel:	+43(3842)98282-42	Fax:	+43(3842)98282-02
---------------------------------------------------------------------------

Re: [Openfoam-extend-general] The patch-branch and the git-branch

From: Håkan N. <ha...@ch...> - 2008-09-05 07:04:15

> So I guess I'll have to have a test-installation that I
> apply patches to before upgrading the production version.
>
> How do you deal with issues like that?

I basically rely on you that there is no problem with the patch version 
:-)

My cluster administrator didn't really like that there should be a patch 
version that updates every now an then either. As you say, people might 
run into problems all of a sudden even if they are running the same code 
and the same case that worked before. That is not good.

It would be good with a solution where patched libraries do not rename or 
overwrite previous patches, and that one could choose which patch version 
that should be linked to by specifying the version number through an 
enviroment variable. I guess that there must be a solution for this, we 
are probably not the first to encounter this problem.

-- 
Håkan.

Note that my e-mail address has changed to ha...@ch....
+-------------------------------------------------------------------------+
| Håkan Nilsson                     |                                     |
| Ph.D., Assistant Professor        | Tel:   (+46)31-772 1414             |
| Applied mechanics, Fluid Dynamics | Fax:   (+46)31-18 09 76             |
| Chalmers University of Technology | E-mail:   ha...@ch...          |
| SE-412 96 Gothenburg              | Homepage:                           |
| SWEDEN                            |    http://www.tfd.chalmers.se/~hani |
+-------------------------------------------------------------------------+