Re: [Openev-discuss] Re: problem (!) with gv_view_area_get_volume()

[s d. <syl...@ya...>]

--- Frank Warmerdam <war...@po...> wrote:
...

> So my objectivess would be:
> 
>   o Avoid making the code more complicated ... for
> instance, do
>     not littler #ifdefs all over the place for the
> different types.
> 
>   o Use meaningful names for types or other macros. 
> In particular
>     avoid names that would imply something that
> might be wrong.
>     (ie. using gvfloat for a double precision type).
> 
>   o Take greatest care to ensure no breakage for the
> default float
>     case.
> 
> 
> > 
> > I think that it will make our life easer.
> > 
> > For instance the tessalator work in double and
> also
> > PROJ4 so floats need to be converted back to
> double.
> 
> Well, some of the simplication that could come if we
> went
> completely via double won't be achieved since we
> would be maintaining
> "due mode" code.
> 
> PS. You can consider yourself approved as an OpenEV
> developer.  If you
> can setup a SourceForge account and let me know, I
> will grant the required
> CVS access.
> 

Frank,

I'm preparing the patch. I'll put in the name you
suggested.

Before committing it to CVS I would like
that you try it yourself with various data. 
Whether the patch is applied or not
should not make any difference (theoreticaly).
But switch to double might not after the patch is 
commited if the code overlap with new code.

I hope to be done today and then I'll mail 
you the patch. 

My loggin/e-mail:
sduclos at users.sourceforge.net


Thanks,

Sylvain. 


__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com