Hi,
Code looks good and tests well. I'm now working on integrating it with the new fee sheet improvements; turns out it's a bit more complicated than I initially thought, but almost there.
-brady
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
From what I can see from the MU2 code, there are two things that need to change with the fee sheet stuff. code_check.php needs to be updated to use ct_prob instead of ct_diag, and update_issues in fee_sheet_queries needs to be updated to handle the new modification date field.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The problem is what happens when a user uses ICD9 for billing and snomed for medical problems. This means your functions to make problems from diagnostic codes and vice versa should not happen. I have gotten it to work in a rudimentary fashion .In commit link below the mods in custom/code_types.inc.php and effectively control this well. The other mods are simply my initial attempts to not show the checkbox in the P column on the justification screen to make it nicer (otherwise it simply ignores it when checkes); note this code is still broken as I work through the solution to not show the checkbox below the P. Here is the code (again, it is broken for now): http://github.com/bradymiller/openemr/commit/ec89528fb3c33f8dbe4661003047423072d485e0
-brady
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
In below paragraph, meant to say:
"In commit link below the mods in
custom/code_types.inc.php and interface/forms/fee_sheet/review/fee_sheet_queries.php effectively control this well."
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Code looks "ok." I'm not sure the restriction makes sense though... It implies that ICD9 isn't allowed in a problem list at all. People shouldn't have to remove existing ICD9 coded problems as part of MU2. And you also make it so that the ICD9 problems can't be kept track of for billing re-use.
Does the MU2 requirement explicitly forbids ICD9?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Kevin,
The behavior is completely up to the user. I am just making it support the option when a user sets a different code type for billing and medical problems. So, this will allow users, if they want, to compartmentalize ICD9 into billing codes only and SNOMED into medical problems only. Note MU2 requires problems to be coded into SNOMED codes (I am guessing could also be done by translating ICD9 codes to SNOMED codes on the fly, but this would be far more complicated, although I am guessing it is where things will head in the future; because it seems ver odd to have separate coding like that). Note that the fee sheet behavior does not get effected if a user sets them to problem and diag, which is the default.
-brady
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Documentation
Hi Vinish,
I placed a review on github.
-brady
Hi Brady,
I have made the modifications suggested.
GitHub Path:
https://github.com/zhhealthcare/openemr/commit/problem_list_v2
Thanks & Regards
ZH HealthCare
Hi Vinish,
Placed a review on github.
thanks,
-brady
Hi Brady,
Made the modifications suggested.
GitHub Path:
https://github.com/zhhealthcare/openemr/commit/problem_list_v3
Thanks & Regards
ZH HealthCare
Hi,
Code looks good and tests well. I'm now working on integrating it with the new fee sheet improvements; turns out it's a bit more complicated than I initially thought, but almost there.
-brady
From what I can see from the MU2 code, there are two things that need to change with the fee sheet stuff. code_check.php needs to be updated to use ct_prob instead of ct_diag, and update_issues in fee_sheet_queries needs to be updated to handle the new modification date field.
Hi Kevin,
The problem is what happens when a user uses ICD9 for billing and snomed for medical problems. This means your functions to make problems from diagnostic codes and vice versa should not happen. I have gotten it to work in a rudimentary fashion .In commit link below the mods in custom/code_types.inc.php and effectively control this well. The other mods are simply my initial attempts to not show the checkbox in the P column on the justification screen to make it nicer (otherwise it simply ignores it when checkes); note this code is still broken as I work through the solution to not show the checkbox below the P. Here is the code (again, it is broken for now): http://github.com/bradymiller/openemr/commit/ec89528fb3c33f8dbe4661003047423072d485e0
-brady
In below paragraph, meant to say:
"In commit link below the mods in
custom/code_types.inc.php and interface/forms/fee_sheet/review/fee_sheet_queries.php effectively control this well."
Code looks "ok." I'm not sure the restriction makes sense though... It implies that ICD9 isn't allowed in a problem list at all. People shouldn't have to remove existing ICD9 coded problems as part of MU2. And you also make it so that the ICD9 problems can't be kept track of for billing re-use.
Does the MU2 requirement explicitly forbids ICD9?
Hi Kevin,
The behavior is completely up to the user. I am just making it support the option when a user sets a different code type for billing and medical problems. So, this will allow users, if they want, to compartmentalize ICD9 into billing codes only and SNOMED into medical problems only. Note MU2 requires problems to be coded into SNOMED codes (I am guessing could also be done by translating ICD9 codes to SNOMED codes on the fly, but this would be far more complicated, although I am guessing it is where things will head in the future; because it seems ver odd to have separate coding like that). Note that the fee sheet behavior does not get effected if a user sets them to problem and diag, which is the default.
-brady
Hi,
Ok, got it working well. Here is the branch:
https://github.com/bradymiller/openemr/commits/zhhealthcare-problem_list_v3-fee-sheet-integrate_V5
(1st commit is the fee sheet integration and 2nd commit is zh's problem list improvements)
Plan to commit this if no objections.
-brady
Hi Vinish,
I just committed this code to sourceforge. Thank you for this awesome contribution.
-brady