[ODP-dev] Coding Guidelines

[Norman M. <no...@se...>]

Hi Alex, Hi Co-Workers,

I really like the idea of having coding guidelines, and a agree with =
you,
that we should write them before 0.5.0 will be published, but:

1) I strongly disagree with 2.ii "Where to put braces"

I hate this:
  if (condition)=20
  {
    do_something
  }

for me this should be:

  if (condition) {
    do_something
  }

[And yes, I started programming with emacs and still use this. I do it =
in C,
C++, Java and PHP ... AND NOT Pascal! I hate this { =3D BEGIN, } =3D END =
stuff.
And yes, I do write=20
  IF condition THEN BEGIN
     do_something;
  END;

And not:
  IF condition THEN
  BEGIN
    do_something;
  END;
]

2) I don't like the part of "Quoting strings", where it said that you =
should
use this:

	$post_url =3D
"{$phpbb_root_path}posting.$phpEx?mode=3D$mode&start=3D$start";

instead of that:

	$post_url =3D $phpbb_root_path . 'posting.' . $phpEx . '?mode=3D' .
$mode . '&start=3D' . $start;

I don't think that the second is overcrowded.


The rest is more or less okay for me.


Yours,
Norman