Menu

#230 If a header line is split immediately after colon, it is not processed correctly

2.10.1
open
None
5
2015-10-07
2015-08-18
No

We have come across emails that have a List-Unsubscribe header that is split due to being too long, and the split happens immediately after the colon. So, we see "List-Unsubscribe:<cr><lf><sp>..."

This does not, it appears to me, to be correctly handled by libopendkim v2.10.3

There was a recent change (a9f167344c3d463372f07edc85d12d84f4849c23) which dealt with lines split before the colon, but I don't think it deals with lines split immediately after.

I'm not currently in a position to test this, although I will endeavour to do so as soon as I can, but I think the DKIM_ISWSP to DKIM_ISLWSP change in dkim-canon.c needs to be made at line 391 too:

    /* skip all spaces before first word */
    while (*p != '\0' && DKIM_ISWSP(*p))
        p++;

to

    /* skip all spaces before first word */
    while (*p != '\0' && DKIM_ISLWSP(*p))
        p++;

Please note, this is present in 2.10.3, but I'm unable to select that in the bug tracker for some reason.

Related

Bugs: #226

Discussion

  • Murray S. Kucherawy

    • assigned_to: Murray S. Kucherawy
     
  • Murray S. Kucherawy

    I think this was reported as bug #226 but somehow the wrong fix got committed and released in the 2.10.x line.

    This fix will be in the next release.

     
  • David Stevenson

    David Stevenson - 2015-10-07

    Ah yes, sorry for the duplicate, and thanks for fixing this in the next release :)

     

Log in to post a comment.