Menu

#153 PU Joint 2 doesn't add constraint for stops

In_STABLE
closed
nobody
Bug Fix (53)
5
2014-02-04
2009-06-23
Sean
No

I found a bug in ode/src/joints/pu.cpp that was discussed in
http://groups.google.com/group/ode-users/browse_thread/thread/c2f03582b49471a4/800b525c850be05b?lnk=gst&q=pu#800b525c850be05b

The stops constraints are not added to the list for the second axis of
the PU joint. All that needs to be done is adding the following line
at line 434:

row += limot2.addLimot( this, info, row, ax2, 1 );

Would someone be able to add this to the SVN repository?

Thank you!

Here's the context if needed.

int row = 3 + limot1.addLimot( this, info, 3, ax1, 1 );
row += limot2.addLimot( this, info, row, ax2, 1 );

if ( node[1].body || !(flags & dJOINT_REVERSE) )
limotP.addLimot( this, info, row, axP, 0 );
else
{
axP[0] = -axP[0];
axP[1] = -axP[1];
axP[2] = -axP[2];
limotP.addLimot ( this, info, row, axP, 0 );
}

Discussion

  • Remi Ricard

    Remi Ricard - 2009-06-26

    Hi,

    This is the fix I suggested to one of the ode user in march.
    Since we have the same thing I will do the commit.

    Thank for the reminder.

    Remi

     
  • Daniel K. O.

    Daniel K. O. - 2014-02-04

    Closing since this appears to have been fixed.

     
  • Daniel K. O.

    Daniel K. O. - 2014-02-04
    • status: open --> closed
    • Group: --> In_STABLE
     

Log in to post a comment.