Re: [Opencore-amr-devel] Crash in amrnb encoder

[Morten T. <mo...@ph...>]

I confirmed that this was the issue.
Some malformed packet arrived with CMR=13, and the implementation tried to switch to that mode for encoding which resulted in a crash.

Best regards,
Morten

Martin Storsjö <ma...@ma...> skrev følgende den 09.11.2017, 11.47:

    On Wed, 8 Nov 2017, Morten Tryfoss wrote:
    
    > Hello again,
    >
    > I notice this:
    > Pitch_fr (st=0x7f1584649d60, mode=13, T_op=0x7f1535178440, exc=0x7f158425ae6a, xn=0x7f15351787e0, h=0x7f158425b080, L_subfr=40, i_subfr=0, pit_frac=0x0, resu3=0x0, ana_index=0x0, pOverflow=0x0) at ../opencore/codecs_v2/audio/gsm_amr/amr_nb/enc/src/pitch_fr.cpp:1336
    >
    > Mode=13? If that’s the mode supplied to the wrapper function, there’s probably a usage error outside the lib. 13 is defined as unused for AMR-NB?
    
    Indeed, if that's passed from the surrounding code somehow, that surely 
    can be the cause of your crash.
    
    // Martin