Menu

#60 Date Control Squished

v1.3 Testing
open
nobody
5
2010-03-26
2010-03-26
BTee
No

Definitely on the properties page and maybe elsewhere, the date control seems a little too squished. The arrows on either side of the month/year are actually covering up part of the month/year.

Discussion

  • mwelburn

    mwelburn - 2010-04-05

    a quick fix for this would be to add one or two   inside the label definition for individual and group columns within dashboard.jsp. This would give the label the additional space to the right where the arrow would overlap (this only occurs where the contents of the column are less wide than the label anyway). I'm afraid this is likely more of a yui issue than our code, but none of the yui examples allow both resizing and sorting, so it's hard to be able to verify in a controlled environment.

    An example of this implementation:

    var myColumnDefs = new Array();
    <c:forEach items="${individualColumns}" var="indColumn">
    var o = {
    key:"${indColumn.name}",
    label:"${indColumn.label}&nbsp;",
    sortable:${indColumn.sortable},
    formatter:${indColumn.formatter},
    resizeable: ${indColumn.resizeable}
    }
    myColumnDefs.push(o);
    </c:forEach>

     
  • mwelburn

    mwelburn - 2010-04-05

    actually disregard the previous comment, i was interpreting the bug as something else.

     
  • mwelburn

    mwelburn - 2010-04-05

    After looking again, it appears this is only the case for some of the longer month names like October and November. The easiest solution would be to just use abbreviations like Oct, Nov, etc, and then we'd never have issues with month names being too long. Otherwise I fear we will just have to widen the date control to an unnecessarily wide size to accomadate the widest possible month + year combination, at the expense of not fitting in the defined space in say the search form

     
  • mwelburn

    mwelburn - 2010-04-06

    Should be able to use the abbreviated month names by modifying calendarTextInput.tag, and changing the navigator attribute on the calendars to use YAHOO.widget.Calendar.SHORT for the monthFormat.

    Refer to the YUI API documentation:
    http://developer.yahoo.com/yui/docs/YAHOO.widget.Calendar.html

    NOTE: I tried briefly to create a navConfig object to set as the navigator value and it wasn't taking, so there might be something slightly more than needs to be touched.

     
  • mwelburn

    mwelburn - 2010-05-17

    I don't have time to test this in the core build, but I fixed it in a project so if someone wants to verify it works in core they can tally up another sourceforge bug fixed. I'll attach the file here.

     
  • mwelburn

    mwelburn - 2010-05-17

    Here is working code from a project. Note that I tried a few times in core and it didnt seem to work, but I just looked again in my project and it was working.

     
  • mwelburn

    mwelburn - 2010-06-02

    once again i notice this isn't working. i give up

     

Log in to post a comment.

Monday.com Logo