Open Camera / Tickets / #900 Location not saved in Tags for Pixel 6 Pro / Android 12

Anonymous - 2021-12-01

I verified this in the source, the source is correct, in CameraController2.java:424
builder.set(CaptureRequest.JPEG_GPS_LOCATION, location);

It seems to me that the camera2 API has a bug.
Also FreeDCam will not set the location correctly. But gcam will.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Enteq - 2022-01-06

Workaround implemented:
https://sourceforge.net/p/opencamera/code/merge-requests/64/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2022-07-08

Same problem with my Pixel 6 and Open Camera v 1.50.1
If I use original Camera API, the gps location is saved
If I use Camera2 API, the gps location is not saved

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2022-07-08

Yes same problem has appeared here lack of Latitude & Longitude , have just changed phone to a Pixel 6 Pro and whilst the Stamped information appears correctly its not stored in the metadata at all under API2 and incorrect values under API1.!

Open Camera bug.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Shawn Hughes - 2022-09-09

Pixel 6: Now on Android 13. OpenCamera v1.50.1: Still a problem: every image since Nov 25 2021 is missing GPS data. Google Camera images contain GPS data.
Workaround, Enteq, (2022Jan): Now September. Still Open. ?! Is this a fix? Have we uncovered the root cause? A better fix?
Very frustrating as 90% of my images are from Open Camera.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.
- Shawn Hughes - 2022-09-10
  
  Tried API1: I'm generally at 42N 83W. This is what is stored:
  GPS Date/Time : 2022:09:10 12:42:55Z
  GPS Latitude : 1 deg 3' 43.45" N
  GPS Longitude : 944 deg 38' 46.75" W
  GPS Position : 1 deg 3' 43.45" N, 944 deg 38' 46.75" W
  
  Last edit: Shawn Hughes 2022-09-10
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.
- Enteq - 2022-09-13
  
  In this commit a fix has been attempted by @mark-h : https://sourceforge.net/p/opencamera/code/ci/979ef37fa495058546d4ccadd60317d903a23eb8/
  This fix is quite similar to what I did, it also propagates the location into all the necessary places in the code. However, this fix only works, if I enable the X-Night extension. Obviously, as the code says, that fix only triggers if "using extensions" whatever that means. I guess that for some reason, for the Pixel 6 Pro, somewhere in the path the "extensions" are probably "used" internally all the time, so the fix does not cover all necessary paths.
  Repairing that in the official version seems to be quite easy, just modify the official fix a bit more:
  Just make sure that the exif.setGpsInfo(location); is not only called if "using_camera_extensions is True, but also if it is False, as long as "location is True.
  (The only other thing I did is I added the condition (!exif.hasAttribute(ExifInterface.TAG_GPS_LATITUDE) || !exif.hasAttribute(ExifInterface.TAG_GPS_LONGITUDE))
  Just to be sure that an existing GPS location isn't overwritten needlessly, but I am not sure if it is necessary.)
  
  Maybe I'll make a fix for the new version as well, if I find time...
  
  Last edit: Enteq 2022-09-13
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.
  - Enteq - 2022-09-13
    
    This is the fix for the new version. I tested it, it works (the most annoying part of it was updating the android studio...)
    @mark-h : I don't know if the addDateTimeExif needs to be called as well. Up until now I didn't miss it in my images.
    
    diff --git a/app/src/main/java/net/sourceforge/opencamera/ImageSaver.java b/app/src/main/java/net/sourceforge/opencamera/ImageSaver.java index b5defeac..8d3fb1c6 100644 --- a/app/src/main/java/net/sourceforge/opencamera/ImageSaver.java +++ b/app/src/main/java/net/sourceforge/opencamera/ImageSaver.java @@ -3605,12 +3605,12 @@ public class ImageSaver extends Thread { Log.d(TAG, "UserComment: " + exif.getAttribute(ExifInterface.TAG_USER_COMMENT)); } setCustomExif(exif, custom_tag_artist, custom_tag_copyright); + + if (store_location && (!exif.hasAttribute(ExifInterface.TAG_GPS_LATITUDE) || !exif.hasAttribute(ExifInterface.TAG_GPS_LONGITUDE))) { + exif.setGpsInfo(location); + } if( using_camera_extensions ) { addDateTimeExif(exif, current_date); - if( store_location ) { - // also need to store geotagging, since Camera API doesn't support doing this for camera extensions - exif.setGpsInfo(location); - } } else if( needGPSTimestampHack(is_jpeg, using_camera2, store_location) ) { fixGPSTimestamp(exif, current_date);
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    
    Anonymous
    
    Add attachments
    Cancel
    You seem to have CSS turned off. Please don't fill out this field.
    
    You seem to have CSS turned off. Please don't fill out this field.

Mark - 2022-10-06

Thanks for the comments. For Camera2 API this will be fixed for the next version (it seems to be a Pixel bug that it's not putting the information there already, but as noted it's easy to workaround by adding it afterwards).

For old camera API, I can reproduce the problem that the location is present but wrong. Again this seems to be a Pixel 6 Pro bug, but harder to resolve (I could just overwrite the exif info, but risk that affects all devices). In practice I plan to start making Camera2 the default on some devices such as Pixels anyway.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Mark - 2022-10-06

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Location not saved in Tags for Pixel 6 Pro / Android 12

Camera app for Android.

Milestone

Searches

Help

#900 Location not saved in Tags for Pixel 6 Pro / Android 12

Discussion