Menu

#872 OpenCamera crashes with an invalid camera ID (multi-camera)

1.0
open
nobody
None
2022-10-31
2021-08-15
EiQuo7ji
No

Open Camera v1.48.3 on LOS 18.1, Xiaomi Mi 10T Pro

After modifying vendor.camera.aux.packagelist, now OpenCamera sees 8 cameras. However, seemingly there are only 6 cameras, and the trick is that some of these IDs from 0 to 7 are skipped. When Open Camera switches to these skipped IDs, it crashes.

I propose the following two methods to deal with this:
1. Use exception handler to avoid crashes, and when an ID is unavailable, just go to the following ID instead.
2. Possibility to parse a GCam configuration. In fact, there are many configurations shared on xda, and seemingly OpenCamera could take advantage of these. For example, for Mi 10T Pro, there is one:
https://github.com/acervenky/vkpro/blob/e21774b1e335c01071f16664ab9273eb37ee8e30/vk_10tpro.xml#L87
You can see that available IDs are listed.

Discussion

  • Anonymous

    Anonymous - 2021-09-10

    Maybe add an option to blacklist (disable) some ID's from the list? Could be the easiest to implement?

     
  • Anonymous

    Anonymous - 2021-11-10

    I second this, it's the almost the same behavior on Poco X3 Pro where it cycles through ID0, ID2, ID3, ID4 and then the not existing ID5 where off course the preview fails and the app crashes on taking a picture.

    It sounds the easiest to just cycle to the next ID when one is not available.

     
  • Anonymous

    Anonymous - 2022-08-03

    I am experiencing the same issue with a Xiaomi Redmi Note 10 Pro.
    Is it possible to add the possibility to blacklist certain IDs?

     
  • Anonymous

    Anonymous - 2022-10-31

    Bump! Having the same kind of problem with OnePlus 7T Pro. OpenCamera trying to switch to non existing Camera ID4 and crashes. Is it possible to somehow disable the non existing ID's and for the app to just cycle the enabled ID's?

     

Anonymous
Anonymous

Add attachments
Cancel