#738 Torch setting missing

[m d]

I have flash on, auto, off, red eye, but not torch, Why?
Version 1.48.1 on Moto Z2 (nash), LineageOS 17.1 (Android 10)
Camera2 API
Other apps are able to set torch mode with API 2.

[Mark]

Can you post the info under Settings/About please?

[m d]

flash_torch is listed, but i can't select it:
["(nicht) verfügbar" means (not) available]

Open Camera v1.48.1
Code: 77
Package: net.sourceforge.opencamera
Android API version: 29
Device manufacturer: Motorola
Device model: Moto Z2
Device code-name: qcom
Device variant: nash
Language: de
Standard max heap?: 256
Large max heap?: 512
Display size: 1440x2392
Display metrics: 1440x2392
Current camera ID: 0
No. of cameras: 3
Multi-camera?: true
Camera API: Camera2 (Android L)
Photo mode: Standard
Preview resolutions: 1920x1080, 1600x1200, 1440x1080, 1280x960, 1280x768, 1280x720, 1200x1200, 1280x480, 1024x768, 800x600, 864x480, 800x480, 720x480, 640x480, 640x360, 480x640, 480x360, 480x320, 352x288, 320x240, 240x320, 176x144, 160x120, 144x176
Preview resolution: 1600x1200
Photo resolutions: 4000x3000, 2976x2976, 3840x2160, 3264x2448, 3200x2400, 2592x1944, 2688x1512, 2592x1458, 2048x1536, 1920x1080, 1600x1200, 1440x1080, 1200x1200, 1280x960, 1280x768, 1280x720, 1024x768, 1280x480, 800x600, 864x480, 800x480, 720x480, 640x480, 480x640, 640x360, 480x360, 480x320, 352x288, 320x240, 240x320, 176x144, 144x176, 160x120
Photo resolution: 4000x3000
Video qualities: 1, 6_r2592x1944, 6_r2688x1512, 6_r2592x1458, 6_r2048x1536, 6, 5_r1600x1200, 5_r1440x1080, 5_r1200x1200, 5_r1280x960, 5_r1280x768, 5, 4_r1024x768, 4_r1280x480, 4_r800x600, 4_r864x480, 4_r800x480, 4, 3_r640x480, 3_r480x640, 3_r640x360, 3_r480x360, 3_r480x320, 3, 7, 7_r240x320, 2, 2_r144x176, 0_r160x120
Video resolutions: 3840x2160, 2592x1944, 2688x1512, 2592x1458, 2048x1536, 1920x1080, 1600x1200, 1440x1080, 1200x1200, 1280x960, 1280x768, 1280x720, 1024x768, 1280x480, 800x600, 864x480, 800x480, 720x480, 640x480, 480x640, 640x360, 480x360, 480x320, 352x288, 320x240, 240x320, 176x144, 144x176, 160x120
Video quality: 6
Video frame width: 1920
Video frame height: 1080
Video bit rate: 17000000
Video frame rate: 30
Video capture rate: 30.0
Video high speed: false
Video capture rate factor: 1.0
Auto-level?: verfügbar
Auto-level enabled?: false
Face detection?: verfügbar
RAW?: verfügbar
HDR?: verfügbar
Panorama?: verfügbar
Gyro sensors?: verfügbar
Expo?: verfügbar
Expo compensation?: verfügbar
Exposure compensation range: -12 to 12
Manual ISO?: verfügbar
ISO range: 50 to 3200
Manual exposure?: verfügbar
Exposure range: 9943 to 316585665
Manual WB?: verfügbar
WB temperature: 1000 to 15000
Optical stabilization?: nicht verfügbar
Optical stabilization enabled?: false
Video stabilization?: verfügbar
Video stabilization enabled?: false
Tonemap curve?: verfügbar
Tonemap max curve points: 512
Can disable shutter sound?: verfügbar
Camera view angle: 67.8022 , 51.18035
Flash modes: flash_off, flash_auto, flash_on, flash_torch, flash_red_eye
Focus modes: focus_mode_auto, focus_mode_macro, focus_mode_locked, focus_mode_infinity, focus_mode_manual2, focus_mode_continuous_picture, focus_mode_continuous_video
Color effects: none, mono, negative, solarize, sepia, posterize, whiteboard, blackboard, aqua
Scene modes: auto, landscape, snow, beach, sunset, night, portrait, sports, steadyphoto, candlelight, fireworks, party, night-portrait, theatre, action
White balances: auto, manual, incandescent, fluorescent, warm-fluorescent, daylight, cloudy-daylight, twilight, shade
Magnetic accuracy?: -1
Using SAF?: false
Save Location: OpenCamera
Save Location SAF:
Parameters: None

[Mark]

As in the icon doesn't show, or it does but doesn't do anything?

If it doesn't show, can you send me a screenshot with the popup menu open please?

[m d]

It doesn't show. But there is no menu, the flash symbol cycles through the options.
When I set to alternative flash in Debug options, only the red eye option goes away.
And Camera 1 API doesn't bring torch either. Same for front camera.

In video mode the (two) flash options with torch appear in the popup menu and I can use it.
While in photo mode there is only a flash symbol on the main screen.

[m d]

Btw. saving setting should (optionally) go the external storage. Now when I deinstall the app the settings file is gone.

[m d]

Ok I found it. But it's a bug to not support the torch on the cycle icon (without notice).

[Mark]

Thanks for the update. This was an intentional decision because otherwise it can be a problem that if a user wants to switch say from flash on to flash off, they can't do that without turning the torch on briefly whilst cycling. I'll at least update the preference text to make that clearer.

I'll think if there are better ways to do it. E.g., maybe the torch icon (or all flash icons) should still be shown on the popup menu, or maybe there should be an optional separate on-screen icon for torch on/off.

[m d]

Yes at least keep the torch on the popup (not sure if a notice then would be necessary).
Or maybe remove the cycle button altogether ... cycling is a bit confusing anyway

[sergio]

To switch torch for photo mode, I need to switch to video mode, turn on torch and switch back.
Is there a way directly from the photo mode?

[Mark]

Are you using the on-screen icon for flash (Settings/On screen GUI/"Show flash icon")? Or are the flash icons in photo mode on the popup menu?

[sergio]

1. Show flash icon is on, but the button cycles through Red Eye Flash Off Flash Auto Flash On, there is no Torch in this list.

2. There is no torch button in popup menu in photo mode, only in video mode.

[m d]

Don't know why but I don't have this problem anymore with Open Camera v1.48.2

[sergio]

v1.48.2

[m d]

Ok in cycle mode the torch is missing, but not in the popup ...
so actually nothing has changed I guess ;(

[sergio]

Is any update there?

[Mark]

See comment https://sourceforge.net/p/opencamera/tickets/738/#7a5e/72a5 , this is intentional behaviour when using the on-screen flash cycle button, although I note some ways it could be improved for in future.

[sergio]

Is there a way to turn torch on in the photo mode? I don't see it.

[Mark]

If you want the torch option, you'll have to stick with the flash icons being in the popup menu I'm afraid (i.e., disable Settings/On screen GUI/"Show flash icon").

[sergio]

Indeed, disabling Show flash icon brings torch back.

intentional

What's wrong with turning the torch on if a user wants to switch say from flash on to flash off?

I'll at least update the preference text to make that clearer.

I believe it should be kept open until a solution is found.

[Anonymous]

May you Please, let me add Torch to Photo.mode by Some option In config mode. Or please change cycle button to pop-up.

Please