#20 Torch flash mode does not turn off

[Joao Soares Veiga]

Hello,
First, thanks for a superb app.

I'm using 1.16 on Nexus 5, 4.4.4.

In camera mode, when cycling through the flash modes, once you get to "torch" mode, the flash LED goes on, but does not turn off until you get to the "flash off" mode, so the modes between torch and off (redeye reduction, auto) are stuck with the LED on.

The workaround I'm using is to quickly go to film mode then back to picture mode.

If the "flash off" mode is moved to just after the "torch" mode in the cycling sequence, the problem would be gone with minimal code change.

Thanks again, debug log follows:
Joao S Veiga

Open Camera v1.16
(c) 2013-2014 Mark Harman
Released under the GPL v3 or later
Package: net.sourceforge.opencamera
Android API version: 19
Device manufacturer: LGE
Device model: Nexus 5
Device code-name: hammerhead
Device variant: hammerhead
Standard max heap? (MB): 192
Large max heap? (MB): 512
Display size: 1080x1776
Current camera ID: 0
Preview resolutions: 1920x1080, 1280x960, 1280x768, 1280x720, 1024x768, 800x600, 800x480, 720x480, 640x480, 352x288, 320x240, 176x144
Photo resolutions: 3264x2448, 3200x2400, 2592x1944, 2048x1536, 1920x1080, 1600x1200, 1280x960, 1280x768, 1280x720, 1024x768, 800x600, 800x480, 720x480, 640x480, 352x288, 320x240, 176x144
Video quality: 1, 5_r1280x960, 5_r1280x768, 5, 4_r1024x768, 4_r800x600, 4_r800x480, 4, 3_r640x480, 3, 7, 0_r176x144
Video resolutions: 1920x1080, 1280x960, 1280x768, 1280x720, 1024x768, 800x600, 800x480, 720x480, 640x480, 352x288, 320x240, 176x144
Auto-stabilise?: Available
Face detection?: Available
Video stabilization?: Not available
Flash modes: flash_auto, flash_off, flash_on, flash_torch, flash_red_eye
Focus modes: focus_mode_auto, focus_mode_infinity, focus_mode_macro, focus_mode_manual, focus_mode_continuous_video
Color effects: none, mono, negative, solarize, sepia, posterize, whiteboard, blackboard, aqua
Scene modes: auto, landscape, snow, beach, sunset, night, portrait, sports, steadyphoto, candlelight, fireworks, party, night-portrait, theatre, action
White balances: auto, incandescent, fluorescent, warm-fluorescent, daylight, cloudy-daylight, twilight, shade
ISOs: None
Parameters: video-size=1920x1080;preferred-preview-size-for-video=1920x1080;preview-size-values=1920x1080,1280x960,1280x768,1280x720,1024x768,800x600,800x480,720x480,640x480,352x288,320x240,176x144;video-size-values=1920x1080,1280x960,1280x768,1280x720,1024x768,800x600,800x480,720x480,640x480,352x288,320x240,176x144;preview-format=yuv420sp;preview-format-values=yuv420p,yuv420sp,;preview-fps-range-values=(15000,15000),(24000,24000),(7000,30000),(30000,30000);preview-frame-rate-values=15,24,30;picture-size-values=3264x2448,3200x2400,2592x1944,2048x1536,1920x1080,1600x1200,1280x960,1280x768,1280x720,1024x768,800x600,800x480,720x480,640x480,352x288,320x240,176x144;picture-format=jpeg;picture-format-values=jpeg;jpeg-thumbnail-width=320;jpeg-thumbnail-height=240;jpeg-thumbnail-size-values=512x288,480x288,256x154,432x288,320x240,176x144,0x0;jpeg-thumbnail-quality=90;rotation=0;whitebalance=auto;whitebalance-values=auto,incandescent,fluorescent,warm-fluorescent,daylight,cloudy-daylight,twilight,shade;effect-values=none,mono,negative,solarize,sepia,posterize,whiteboard,blackboard,aqua;antibanding=auto;antibanding-values=off,60hz,50hz,auto;scene-mode=auto;scene-mode-values=auto,landscape,snow,beach,sunset,night,portrait,sports,steadyphoto,candlelight,fireworks,party,night-portrait,theatre,action;flash-mode-values=off,auto,on,torch,red-eye;focus-mode-values=infinity,auto,macro,continuous-video,continuous-picture;max-num-focus-areas=1;focal-length=3.97;max-exposure-compensation=12;min-exposure-compensation=-12;exposure-compensation-step=0.166667;auto-exposure-lock=false;auto-exposure-lock-supported=true;auto-whitebalance-lock=false;auto-whitebalance-lock-supported=true;max-num-metering-areas=1;zoom=0;max-zoom=99;zoom-ratios=100,103,106,109,112,115,118,121,124,127,130,133,136,139,142,145,148,151,154,157,160,163,166,169,172,175,178,181,184,187,190,193,196,199,203,206,209,212,215,218,221,224,227,230,233,236,239,242,245,248,251,254,257,260,263,266,269,272,275,278,281,284,287,290,293,296,299,303,306,309,312,315,318,321,324,327,330,333,336,339,342,345,348,351,354,357,360,363,366,369,372,375,378,381,384,387,390,393,396,399;zoom-supported=true;smooth-zoom-supported=false;focus-distances=Infinity,Infinity,Infinity;max-num-detected-faces-hw=5308677;max-num-detected-faces-sw=0;video-frame-format=android-opaque;video-snapshot-supported=true;video-stabilization=false;video-stabilization-supported=false;effect=none;exposure-compensation=0;jpeg-quality=90;focus-mode=auto;focus-areas=(0,0,0,0,0);metering-areas=(0,0,0,0,0);picture-size=3264x2448;preview-size=1280x960;recording-hint=false;preview-frame-rate=15;preview-fps-range=15000,15000;flash-mode=auto;horizontal-view-angle=59.6295;vertical-view-angle=46.66

[Mark]

That seems strange, but your proposed fix seems a reasonable workaround, so I'll add that for v1.18.

Out of interest, when you switch to video and back, does the torch turn off when switching to video, or only when you then switch back to photo? This might help track down what's really going on.

[Joao Soares Veiga]

Hi Mark, thanks for the reply.

Here's a detailed sequence of events for the debugging:

1. Starting with the app in camera mode, flash = auto, led off.
2. Cycle flash off, on, torch. Led turns on.
3. Cycle to redeye. Led stays on.
4. Cycle to auto. Led stays on.

From this state:
. Touching film mode turns the led off immediately as the mode switches.
. Touching the "switch to front camera" also turns the led off immediately
(even before the display brings the front camera image up).
. Touching the gears (settings) do not turn the led off. It stays on with
the settings menu showing. Touching the return button to exit settings then
turns the led off when it returns to the camera view.

Tried in my son's Galaxy Note 3 (4.4.2) and it does not happen, so it's
probably just on the Nexus 5 and/or 4.4.4.

Best regards, and if you need any further information, just let me know.

Joao

Edit: removed quoted text added by responding to this via email and
Additional info: it also happens in filming mode (torch mode leaves the led on until you cycle to flash off or workaround as above)

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

[Mark]

It turns out that this wasn't fixed in v1.18 due to a bug in the code (unfortunately I wasn't able to test it). I now have a Nexus 6 which reproduces the problem, and I've put a fix in for v1.23.

[Anonymous]

Continuous focus also will not turn off.