#1328 Gallery does not open, because of wrong Intent string

[Özgür Emir]

Hi!

First of all, really neat app you got us there!

But since beginning I always wondered, why I am not able to watch the new shot media.
Now I did some digging. My assumption is, that you are using a wrong (or depricated?) Intent string to open the media.

This
final String REVIEW_ACTION = "com.android.camera.action.REVIEW"; (sourceforge.net)
should be replaced by
final String REVIEW_ACTION =android.provider.MediaStore.ACTION_REVIEW; (developer.android.com)
or so. Sorry, I do not have a running Android dev environment, so this is only some pseudo stuff...

[Özgür Emir]

this should be it

            String REVIEW_ACTION;
            if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.Q) {
                REVIEW_ACTION = android.provider.MediaStore.ACTION_REVIEW;
            } else {
                REVIEW_ACTION = "com.android.camera.action.REVIEW";
            }

[Mark]

Thanks, I'll take a look. com.android.camera.action.REVIEW is an unofficial intent as it was used by the stock Android camera years ago and because a kind of unofficial standard. I hadn't noticed MediaStore.ACTION_REVIEW, so I'll see if thican replace it. Which gallery app are you using - or if it's the stock gallery, what device is this?

[Özgür Emir]

Cool, I am looking forward for the update.

Yeah, I already guessed, that this is either legacy or hacky code. :)

I am using a Samsung S9+ (SM-G965F) with LineageOS 20 20241227-NIGHTLY.
The gallery app I am running is com.android.gallery3d Version 1.1.40030.
But as far as I remember, it did not work with other, alternate gallery apps from F-Droid either.

[Mark]

I've added support for MediaStore.ACTION_REVIEW for the next version, but I'd had to add it as a second priority to "com.android.camera.action.REVIEW" - a problem is that some older gallery apps only support "com.android.camera.action.REVIEW" (even though in theory they're the ones that should be updated, users will complain to me if Open Camera no longer works with it...)

I wasn't sure what your symptoms were - if you weren't seeing any options at all for viewing photos/videos, then the new version should fix it (as long as have something installed that responds to MediaStore.ACTION_REVIEW). But if you have at least one app for com.android.camera.action.REVIEW, then those will still take priority.

See my comment at https://sourceforge.net/p/opencamera/tickets/1300/ - as I say there, I may add a debug switch to give users more control.