[OpenCA-Devel] Re: [openca-cvsdev] CVS: openca-0.9/src/cgi-bin/cgi-raserver/cmds confirm_revreq,1.8,1.9

[<jo...@fo...>]

On 02-04-29 17:22:59 CEST, ope...@li... wrote:
> + my $crr_serial = getRequired ("ModuleID") + $crr_serial * 2**getRequired ("ModuleShift");

is there any reason to use the floating point pow(3) in
  $id + $s * 2**$shift
instead of the plain and simple integer shift
  $id + ($s << $shift)
?

well, i'd prefer
  ($s << $shift) | $id
i.e. upper bits to the left, and combine shift with boolean or instead
of arithmetic add...

rj