Re: [Openbsdbinpatch-misc] "combo" diff

[G. S. G. G. <ger...@gm...>]

On 4/21/08, Mike Erdely <mi...@er...> wrote:
> Below is a diff to bsd.binpatch.mk that adds a "combo" target.
> It iterates through the binpatch packages <= ${PATCH} untarring
> them to a temporary location.  Then creates an "upto${PATCH}" tarball.
>
> Thoughts?

Ok, I have looked closer and I have two questions.


> --- bsd.binpatch.mk	Mon Mar 31 01:40:25 2008
> +++ bsd.binpatch.mk	Mon Mar 31 01:51:57 2008
> @@ -257,6 +257,26 @@ package: build
>  	@echo "|"
>  	@echo "+-------------------------"
>
> +${PACKAGEDIR}/${DISTNAME}-${ARCH}-upto${PATCH}.tgz:
> ${PACKAGEDIR}/${FULLPKGNAME}.tgz
> +	@echo "===>  Building combination package for ${PATCH}"
> +	@rm -Rf ${.CURDIR}/.combo_pkg
> +	@mkdir -p ${.CURDIR}/.combo_pkg

1. did you choose ${.CURDIR} instead of ${.WRKDIR} for creating
.combo_pkg for a reason?


2. Does -C has any purpose here?

> +	@tar -C ${WRKINST} -czpf
> ${PACKAGEDIR}/${DISTNAME}-${ARCH}-upto${PATCH}.tgz \
> +	  `(cd ${.CURDIR}/.combo_pkg && find . -type f)`
> +	@rm -Rf ${.CURDIR}/.combo_pkg

Thanks in advance.
-- 
Gerardo Santana