Re: [Openbsdbinpatch-misc] "combo" diff

[Mike E. <mi...@er...>]

On Mon, Apr 21, 2008 at 02:57:42PM -0500, Gerardo Santana G?mez Garrido wrote:
> Hi Mike,
> 
> I guess this line
> +         mypkg=${DISTNAME}-${ARCH}-`printf "%03d\n" $$count`.tgz; \
> 
> shoud be
> +         mypkg=${DISTNAME}-${ARCH}-`printf "%03d" $$count`.tgz; \
> 
> without the new line.

Haha!  Of course the \n snuck in there from testing.  Strangely, it
works even with the \n in there.  But, you're right... It shouldn't be
there.

> It looks fine to me.
> 
> The only issue I see is that the user may expect that this new target
> also builds the packages, if they don't exist. Nothing that the
> documentation can't fix though.
> 
> Any other thought?

I think documentation is the way to go.

> -- 
> Gerardo Santana

-ME