The patch replaces some calls to IsNear with IsNear_mod, but adds a new function IsNear. That code doesn't compile, 'unknown symbol IsNear_mod' or something like that. I think you've meant the new function to be called IsNear_mod and renamed it when I've tested your patch.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
even with the funcion in obutils.cpp renamed to IsNear_mod as probably intended I get this error on ppc64le:
Start 10: rotor_Test
10/60 Test #10: rotor_Test .......................***Failed Error regular expression found in output. Regex=[FAIL] 0.07 sec
/builddir/build/BUILD/openbabel-2.3.2/test/rotortest.cpp:77: IsNear_mod(fabs(RAD_TO_DEG * rotor.CalcTorsion(mol->GetCoordinates())), 180.0, 360.0, 1.0) (FAIL)
/builddir/build/BUILD/openbabel-2.3.2/test/rotortest.cpp:109: IsNear_mod(fabs(RAD_TO_DEG * rotor.CalcTorsion(mol->GetCoordinates())), 180.0, 360.0, 1.0) (FAIL)
/builddir/build/BUILD/openbabel-2.3.2/test/rotortest.cpp:123: IsNear(RAD_TO_DEG * rotor.CalcTorsion(mol->GetCoordinates()), 180.0, 1.0) (FAIL)
.. Renamed? The patch does a lot more than that.
The patch is pretty raw though; iirc I didn't even check if it compiles or not.
The patch replaces some calls to IsNear with IsNear_mod, but adds a new function IsNear. That code doesn't compile, 'unknown symbol IsNear_mod' or something like that. I think you've meant the new function to be called IsNear_mod and renamed it when I've tested your patch.
Yeah, I forgot to change the name of the function in the translation unit.
Here's a new patch that compiles properly and should fix the issues with the negative torsion angles.