#893 cppcheck: Prefer prefix ++/-- operators for non-primitive types (patch attached)

[serval24]

Hello,

Cppcheck reported several times (about 100) this:
Prefer prefix ++/-- operators for non-primitive types

I attached a patch to fix them + some 2 or 3 assert

Julien

[Geoff Hutchison]

Merged. Thanks! (Feel free to use GitHub and make pull requests for easier merges and code-review.)

[serval24]

Hi Geof,

I updated Openbabel and saw nothing. However, I noticed you merged the
patch for Avogadro.

julien@julienPC:~/avogadro/avogadro$ git pull -r && git log -1
Current branch master is up to date.
commit 07060934342ab621d42b77d0aa5e7b2387a46f3a
Author: Julien Nabet serval2412@yahoo.fr
Date: Tue Sep 24 22:59:38 2013 +0200

 Coverity: fix some memory leaks

 Change-Id: I7a1ca207ace6a5d89cf447551619c11849d93c6a

julien@julienPC:~/openbabel$ git pull -r && git log -1
Current branch master is up to date.
commit 4bdca389075d90fe25d59708a7034a4c578d431c
Merge: 63fe928 3ca6aa3
Author: Geoff Hutchison geoff.hutchison@gmail.com
Date: Wed Sep 25 08:13:54 2013 -0700

 Merge pull request #29 from Reinis/bindings_scala

 scala: Add an example program in Scala using Java bindings

Am I missing something?
Thanks anyway! :-)

Julien

On 30/09/2013 21:07, Geoff Hutchison wrote:

Merged. Thanks! (Feel free to use GitHub and make pull requests for
easier merges and code-review.)

---

[bugs:#893] http://sourceforge.net/p/openbabel/bugs/893/ cppcheck:
Prefer prefix ++/-- operators for non-primitive types (patch attached)

Status: closed
Labels: cppcheck
Created: Thu Sep 26, 2013 04:54 AM UTC by serval24
Last Updated: Thu Sep 26, 2013 04:54 AM UTC
Owner: nobody

Hello,

Cppcheck reported several times (about 100) this:
Prefer prefix ++/-- operators for non-primitive types

I attached a patch to fix them + some 2 or 3 assert

Julien

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/openbabel/bugs/893/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/