Re: [Open64-devel] cleanup patch to remove PROMPF code [LNO+]
Brought to you by:
ributzka,
suneeljain
|
From: David C. <dco...@gm...> - 2012-02-27 02:23:28
|
To answer a few questions: Q: What is PROMPF? A: It is a static analysis feature which generates an additional file (.anl) during compilation. There is a lot of code in LNO to maintain related information in WHIRL, but I don't think it is used to make any changes during compilation. I believe the expectation was that another tool would be used to interpret the analysis file... maybe someone from the SGI days can clarify. Q: Why does the patch remove the Whirl Browser? A: It does not. It only removes the WB code related to PROMPF. Q: Why not maintain or improve this functionality? A: The patch is based on the assumption that no one is using this feature because BUILD_SKIP_PROMPF has always been defined for all targets in Open64. I tried to build a compiler with PROMPF support on x86 and the feature didn't work, because no prompf_anl.so is created and copied to the installation directory, further convincing me that no one is using the feature. On Sun, Feb 19, 2012 at 8:07 PM, David Coakley <dco...@gm...> wrote: > Hi all, > > Here is a patch that removes dead code related to the obsolete PROMPF > feature. The patch is farily large but the changes are > straightforward. Removing this code makes the remaining code easier > to understand, especially for those new to Open64. > > Could one of the gatekeepers review the changes? Thanks, > > -David Coakley / AMD Open Source Compiler Engineering |