Re: [Open64-devel] Code Review Request (bug #721)

[Suneel J. <sun...@gm...>]

We don't yet have a branch for the 4.2.4 release. Please hold off your
checkin for a couple of days. Thanks.

- Suneel


On Mon, Mar 28, 2011 at 3:47 PM, Sun Chan <sun...@gm...> wrote:
> for the release tree, Suneel is the gatekeeper. For tot, please go ahead
> sun
>
> On Tue, Mar 29, 2011 at 2:47 AM, Shin, Jaewook <ja...@hp...> wrote:
>> Hi Sun,
>>
>> Thanks for the approval on this patch. Can I check in the fix now? I know the trunk was frozen for the 4.2.4 release but I am not sure if it's open again.
>>
>> Jaewook
>>
>>
>> -----Original Message-----
>> From: Sun Chan [mailto:sun...@gm...]
>> Sent: Wednesday, March 23, 2011 5:12 AM
>> To: Shin, Jaewook
>> Cc: Zhao, Min; ope...@li...
>> Subject: Re: Code Review Request (bug #721)
>>
>> the fix should be fine.
>> Sun
>>
>> On Wed, Mar 23, 2011 at 8:34 AM, Shin, Jaewook <ja...@hp...> wrote:
>>> Hi Sun,
>>>
>>>
>>>
>>> Could you review the attached patch for bug #721? This patch improves upon
>>> the earlier ones in several ways; First, the generated code goes to GOT only
>>> for symbols that are preemptible (exp_loadstore.cxx:L1180). Second, string
>>> comparison for ".rodata" is eliminated. Third, it keeps CPIC when both PIC
>>> and CPIC are given. This allows further optimizations for CPIC later.
>>> Fourth, this patch covers both -m64 and -m32. Finally, this patch is tested
>>> for both SPEC FP and INT and passed both to the same level as PIC. For both
>>> test suites, it fails only for 416.gamess but PIC also fails for the same
>>> one. Please let me know if you need further information for the patch.
>>> Thanks.
>>>
>>>
>>>
>>> Jaewook
>>>
>>>
>>
>
> ------------------------------------------------------------------------------
> Create and publish websites with WebMatrix
> Use the most popular FREE web apps or write code yourself;
> WebMatrix provides all the features you need to develop and publish
> your website. http://p.sf.net/sfu/ms-webmatrix-sf
> _______________________________________________
> Open64-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/open64-devel
>