#242 Don't call OnHold if SIP hold/retrieve request fails

Unstable_(example)
closed-rejected
nobody
None
5
2013-07-29
2013-07-11
No

We need to call OnHold only if hold/retrieve request succeeded.
Here is a patch.

1 Attachments

Discussion

  • Robert Jongbloed

    • status: open --> closed-rejected
     
  • Robert Jongbloed

    I do not agree with this, if there is no call back on failure, then how does the application know the hold request did not occur? Checking for a call something that does not happen if annoying, needing timers etc. Not good programming practice IMHO.

    It is expected that the application knows if it has requested a hold or not and handles the OnHold() call back accordingly. If it did not get what it expected, it knows it failed.

     
  • Valeriy V. Argunov

    I thought that if OnHold was not called with "HELD" state then Hold didn't occur.
    I.e. we have HELD state only if OnHold was called.
    Anyway, that's not a big issue.

     

Log in to post a comment.