Re: [Opalvoip-user] Bug in OpalRFC2833Proto::SendToneAsync Opal 3.12.9

[Robert J. <ro...@vo...>]

I am sorry, but I really do not think that is the problem. Your issue may
be fixed by a short delay, but there is no logical reason for waiting till
the m_asyncDurationTimer time has started would have any affect
on SendAsyncFrame() as it never examines that variable, it only stops it
under in error cases, so how can it not having been started yet affect if
the packet is transmitted?

There is something else going on, and I think you might need to dig a
little deeper to find it. The short delay may be a clue, do you get the "No
RTP session suitable" or "No payload type to send packet" messages? If not
you mighty consider added a log to:

   if (m_transmitState == TransmitIdle) {

to see if it going out that path.


Robert Jongbloed
*OPAL/OpenH323/PTLib Architect and Co-founder*.

On 28 October 2014 at 00:23, David Jaschuk <dav...@se...>
wrote:

> Hello,
>
> I am using Opal 3.12.9.
>
> There is a bug in the function OpalRFC2833Proto::SendToneAsync in
> (src/codec/rfc2833.cxx). I am not sure if this is a known bug, so i just
> wanted to inform you:
>
> On line 293, the m_asyncDurationTimer is reset with a new value. This
> sets the timer in one-shot mode and queues it to be started by the
> housekeeper. Unfortunately, the housekeeper might be not fast enough to
> start the timer before it is used in OpalRFC2833Proto::SendAsyncFrame
> (line 334).
> This results in no sent DTMF packets.
>
> I did a quickfix with the attached patch, but am aware that there might
> be better ways of fixing this (e.g. by using some kind of mutex).
>
>
> Kind regards
> David
>
> --
> Dipl.-Inf
> David Jaschuk
> Berater
> Entwicklung Client- & Netzwerksicherheit
> Public Sector
> secunet Security Networks AG
> Alt-Moabit 91c
> 10559 Berlin
> Telefon +49-201-5454-3627
> Telefax +49-201-5454-1321
> dav...@se...
> http://www.secunet.com
> Public Sector
> secunet Security Networks AG
>
> ______________________________________________________________________
>
> Sitz: Kronprinzenstraße 30, 45128 Essen, Deutschland
> Amtsgericht Essen HRB 13615
> Vorstand: Dr. Rainer Baumgart (Vors.), Thomas Pleines
> Aufsichtsratsvorsitzender: Dr. Peter Zattler
> ______________________________________________________________________
>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Opalvoip-user mailing list
> Opa...@li...
> https://lists.sourceforge.net/lists/listinfo/opalvoip-user
>
>