[Opalvoip-devel] bug in class OpalMediaFormatInternal, absence method Clone

[Yuriy C. <yur...@gm...>]

Some call stack:

a.dll!PObject::Clone()  Line 457

a.dll!OpalMediaFormat::CloneContents(const OpalMediaFormat * c=0x0b49c458)
Line 986 + 0x15 bytes

a.dll!OpalMediaFormat::MakeUnique()  Line 838 + 0x2b bytes

a.dll!OpalMediaFormat::ToCustomisedOptions()  Line 971 + 0x19 bytes

a.dll!OpalManager::AdjustMediaFormats(const OpalConnection & __formal={...},
OpalMediaFormatList & mediaFormats={...})  Line 895 + 0x13 bytes

a.dll!AOPAL::al::ALManager::AdjustMediaFormats(const OpalConnection &
connection={...}, OpalMediaFormatList & mediaFormats={...})  Line 164
    (my method but it is out some log and call the same method from
supercalss)

a.dll!OpalEndPoint::AdjustMediaFormats(const OpalConnection &
connection={...}, OpalMediaFormatList & mediaFormats={...})  Line 653

a.dll!OpalConnection::AdjustMediaFormats(OpalMediaFormatList &
mediaFormats={...})  Line 889

a.dll!H323Connection::GetMediaFormats()  Line 3757
...

In details:

mediafmt.cxx (line 984) :
void OpalMediaFormat::CloneContents(const OpalMediaFormat * c)
{
  m_info = (OpalMediaFormatInternal *)c->m_info->Clone();
  m_info->options.MakeUnique();
}

m_info is pointer to OpalMediaFormatInternal, so CloneContents call Clone
method on OpalMediaFormatInternal,
but this class does not reimplement PObject::Clone()

object.cxx (line 455):
PObject * PObject::Clone() const
{
  PAssertAlways(PUnimplementedFunction);
  return NULL;
}

So Assert!!!