#616 linker error in libsrtp2.a: multiple definition of 'bit_string'

[Evil.2000]

When compiling version 3.20 of opal the linker complains about multiple use of the bit_string function:

ar cr libsrtp2.a srtp/srtp.o srtp/ekt.o crypto/cipher/cipher.o crypto/cipher/null_cipher.o crypto/cipher/aes_icm_ossl.o crypto/cipher/aes_gcm_ossl.o crypto/hash/null_auth.o crypto/hash/auth.o crypto/hash/hmac_ossl.o crypto/math/datatypes.o crypto/math/stat.o crypto/kernel/crypto_kernel.o crypto/kernel/alloc.o crypto/kernel/key.o crypto/kernel/err.o crypto/replay/rdb.o crypto/replay/rdbx.o crypto/replay/ut_sim.o
ranlib libsrtp2.a
gcc -DHAVE_CONFIG_H -Icrypto/include -I./include -I./crypto/include  -fPIC -Wall -pedantic -Wstrict-prototypes -O4 -fexpensive-optimizations -funroll-loops  -L.  -o crypto/test/cipher_driver crypto/test/cipher_driver.c test/getopt_s.c libsrtp2.a -lcrypto -ldl -pthread   -lsrtp2
gcc -DHAVE_CONFIG_H -Icrypto/include -I./include -I./crypto/include  -fPIC -Wall -pedantic -Wstrict-prototypes -O4 -fexpensive-optimizations -funroll-loops  -I./test -L.  -o crypto/test/datatypes_driver crypto/test/datatypes_driver.c test/util.c libsrtp2.a -lcrypto -ldl -pthread   -lsrtp2
/usr/bin/ld: libsrtp2.a(datatypes.o):(.bss+0x0): multiple definition of `bit_string'; /tmp/ccD2q4VB.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:215: crypto/test/datatypes_driver] Error 1
make[2]: *** [/home/user/Source/opal/make/toplevel.mak:515: /home/user/Source/opal/src/rtp/libsrtp/libsrtp2.a] Error 2
make[2]: *** Deleting file '/home/user/Source/opal/src/rtp/libsrtp/libsrtp2.a'
make[1]: *** [/usr/share/ptlib/make/post.mak:115: optshared] Error 2
make[1]: Leaving directory '/home/user/Source/opal'
make: *** [/usr/share/ptlib/make/autoconf.mak:179: build_top_level] Error 2

Full screenlog attached.

[Evil.2000]

After disabling srtp with ./configure --disable-srtp the compiler complains about strncpy():

Installing BFCP participant headers to ../../../include :
install -m 755 bfcp_participant.h ../../../include/
cd libbfcp/bfcpsrvctl/bfcpsrv ;  make all
gcc  -I /home/user/Source/opal/libbfcp -c bfcp_floor_list.c -o ../../../rel/objs/bfcp_floor_list.o  -I../../../include -O2 -fPIC -Wall -Werror -Wunused -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
g++  -I /home/user/Source/opal/libbfcp -c bfcp_link_list.cpp -o ../../../rel/objs/bfcp_link_list.o -I ../../../include  -O2 -fPIC -Wall -Werror -Wunused
g++  -I /home/user/Source/opal/libbfcp -c bfcp_server.cpp -o ../../../rel/objs/bfcp_server.o -I ../../../include  -O2 -fPIC -Wall -Werror -Wunused
g++  -I /home/user/Source/opal/libbfcp -c bfcp_user_list.cpp -o ../../../rel/objs/bfcp_user_list.o -I ../../../include  -O2 -fPIC -Wall -Werror -Wunused
Installing BFCP server headers to ../../../include/:
install -m 755 bfcp_floor_list.h ../../../include/
install -m 755 bfcp_link_list.h ../../../include/
install -m 755 bfcp_server.h ../../../include/
install -m 755 bfcp_user_list.h ../../../include/
cd libbfcp ; make all
g++  -I /home/user/Source/opal/libbfcp -c BFCPconnection.cpp -o ../rel/objs/BFCPconnection.o -I ../include  -O2 -fPIC -Wall -Werror -Wunused -fno-strict-aliasing
g++  -I /home/user/Source/opal/libbfcp -c BFCP_fsm.cpp -o ../rel/objs/BFCP_fsm.o -I ../include  -O2 -fPIC -Wall -Werror -Wunused -fno-strict-aliasing
BFCP_fsm.cpp: In member function 'void BFCP_fsm::setName(const char*)':
BFCP_fsm.cpp:10:16: error: 'char* strncpy(char*, const char*, size_t)' specified bound 256 equals destination size [-Werror=stringop-truncation]
   10 |         strncpy( m_name , p_name , BFCP_STRING_SIZE ) ;
      |         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[4]: *** [Makefile:34: ../rel/objs/BFCP_fsm.o] Error 1
make[3]: *** [Makefile:72: modules] Error 2
make[2]: *** [/home/user/Source/opal/make/toplevel.mak:522: /home/user/Source/opal/src/sdp/BFCP/lib/libbfcprel.a] Error 2
make[1]: *** [/usr/share/ptlib/make/post.mak:115: optshared] Error 2
make[1]: Leaving directory '/home/user/Source/opal'
make: *** [/usr/share/ptlib/make/autoconf.mak:179: build_top_level] Error 2

Finally disabling bfcp also let make walk through the end.